Skip to content

Commit ae5a3b8

Browse files
arraypadbobinette-net
arraypad
authored and
bobinette-net
committed
chore: Update SecurityAdvisory structs with new fields
SecurityAdvisory now has CVSSSeverities (mentioned in google#4077), see https://docs.github.com/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#security_advisory DependabotSecurityAdvisory also has CVSSSeverities and also Classification, see https://docs.github.com/en/webhooks/webhook-events-and-payloads#dependabot_alert
1 parent 7de90cf commit ae5a3b8

5 files changed

Lines changed: 121 additions & 0 deletions

File tree

‎github/dependabot_alerts.go‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,13 @@ type AdvisoryCVSS struct {
2323
VectorString *string `json:"vector_string,omitempty"`
2424
}
2525

26+
// AdvisoryCVSSSeverities represents the advisory pertaining to the Common Vulnerability Scoring System
27+
// for each supported CVSS version.
28+
type AdvisoryCVSSSeverities struct {
29+
CVSSV3 *AdvisoryCVSS `json:"cvss_v3,omitempty"`
30+
CVSSV4 *AdvisoryCVSS `json:"cvss_v4,omitempty"`
31+
}
32+
2633
// AdvisoryCWEs represent the advisory pertaining to Common Weakness Enumeration.
2734
type AdvisoryCWEs struct {
2835
CWEID *string `json:"cwe_id,omitempty"`
@@ -46,7 +53,9 @@ type DependabotSecurityAdvisory struct {
4653
Description *string `json:"description,omitempty"`
4754
Vulnerabilities []*AdvisoryVulnerability `json:"vulnerabilities,omitempty"`
4855
Severity *string `json:"severity,omitempty"`
56+
Classification *string `json:"classification,omitempty"`
4957
CVSS *AdvisoryCVSS `json:"cvss,omitempty"`
58+
CVSSSeverities *AdvisoryCVSSSeverities `json:"cvss_severities,omitempty"`
5059
CWEs []*AdvisoryCWEs `json:"cwes,omitempty"`
5160
EPSS *AdvisoryEPSS `json:"epss,omitempty"`
5261
Identifiers []*AdvisoryIdentifier `json:"identifiers,omitempty"`

‎github/event_types.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1887,6 +1887,7 @@ type WorkflowRunEvent struct {
18871887
// GitHub API docs: https://docs.github.com/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#security_advisory
18881888
type SecurityAdvisory struct {
18891889
CVSS *AdvisoryCVSS `json:"cvss,omitempty"`
1890+
CVSSSeverities *AdvisoryCVSSSeverities `json:"cvss_severities,omitempty"`
18901891
CWEs []*AdvisoryCWEs `json:"cwes,omitempty"`
18911892
GHSAID *string `json:"ghsa_id,omitempty"`
18921893
Summary *string `json:"summary,omitempty"`

‎github/github-accessors.go‎

Lines changed: 40 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎github/github-accessors_test.go‎

Lines changed: 43 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎github/security_advisories_test.go‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -793,6 +793,10 @@ func TestListGlobalSecurityAdvisories(t *testing.T) {
793793
"vector_string": "CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:C/C:H/I:H/A:H",
794794
"score": 7.6
795795
},
796+
"cvss_severities": {
797+
"cvss_v3": {"vector_string": "CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:C/C:H/I:H/A:H", "score": 7.6},
798+
"cvss_v4": {"vector_string": "CVSS:4.0/AV:N/AC:L/AT:N/PR:H/UI:N/VC:H/VI:H/VA:H/SC:N/SI:N/SA:N", "score": 8.7}
799+
},
796800
"cwes": [
797801
{
798802
"cwe_id": "CWE-400",
@@ -864,6 +868,16 @@ func TestListGlobalSecurityAdvisories(t *testing.T) {
864868
VectorString: Ptr("CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:C/C:H/I:H/A:H"),
865869
Score: Ptr(7.6),
866870
},
871+
CVSSSeverities: &AdvisoryCVSSSeverities{
872+
CVSSV3: &AdvisoryCVSS{
873+
VectorString: Ptr("CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:C/C:H/I:H/A:H"),
874+
Score: Ptr(7.6),
875+
},
876+
CVSSV4: &AdvisoryCVSS{
877+
VectorString: Ptr("CVSS:4.0/AV:N/AC:L/AT:N/PR:H/UI:N/VC:H/VI:H/VA:H/SC:N/SI:N/SA:N"),
878+
Score: Ptr(8.7),
879+
},
880+
},
867881
CWEs: []*AdvisoryCWEs{
868882
{
869883
CWEID: Ptr("CWE-400"),
@@ -977,6 +991,10 @@ func TestGetGlobalSecurityAdvisories(t *testing.T) {
977991
"vector_string": "CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:C/C:H/I:H/A:H",
978992
"score": 7.6
979993
},
994+
"cvss_severities": {
995+
"cvss_v3": {"vector_string": "CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:C/C:H/I:H/A:H", "score": 7.6},
996+
"cvss_v4": {"vector_string": "CVSS:4.0/AV:N/AC:L/AT:N/PR:H/UI:N/VC:H/VI:H/VA:H/SC:N/SI:N/SA:N", "score": 8.7}
997+
},
980998
"cwes": [
981999
{
9821000
"cwe_id": "CWE-400",
@@ -1044,6 +1062,16 @@ func TestGetGlobalSecurityAdvisories(t *testing.T) {
10441062
VectorString: Ptr("CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:C/C:H/I:H/A:H"),
10451063
Score: Ptr(7.6),
10461064
},
1065+
CVSSSeverities: &AdvisoryCVSSSeverities{
1066+
CVSSV3: &AdvisoryCVSS{
1067+
VectorString: Ptr("CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:C/C:H/I:H/A:H"),
1068+
Score: Ptr(7.6),
1069+
},
1070+
CVSSV4: &AdvisoryCVSS{
1071+
VectorString: Ptr("CVSS:4.0/AV:N/AC:L/AT:N/PR:H/UI:N/VC:H/VI:H/VA:H/SC:N/SI:N/SA:N"),
1072+
Score: Ptr(8.7),
1073+
},
1074+
},
10471075
CWEs: []*AdvisoryCWEs{
10481076
{
10491077
CWEID: Ptr("CWE-400"),

0 commit comments

Comments
 (0)