chore: Remove namespace restriction for EnvoyProxy parametersRef reso… (envoyproxy#3544)

phantooom · web-flow · commit b870e3908a72 · 2024-06-05T16:30:44.000-07:00
chore: Remove namespace restriction for EnvoyProxy parametersRef resource
diff --git a/internal/provider/kubernetes/controller.go b/internal/provider/kubernetes/controller.go
@@ -1578,14 +1578,14 @@ func (r *gatewayAPIReconciler) processParamsRef(ctx context.Context, gc *gwapiv1
 	}
 
 	epList := new(egv1a1.EnvoyProxyList)
+	gcParametersRefNamespace := string(*gc.Spec.ParametersRef.Namespace)
 
-	// The EnvoyProxy must be in the same namespace as EG.
-	if err := r.client.List(ctx, epList, &client.ListOptions{Namespace: r.namespace}); err != nil {
-		return fmt.Errorf("failed to list envoyproxies in namespace %s: %w", r.namespace, err)
+	if err := r.client.List(ctx, epList, &client.ListOptions{Namespace: gcParametersRefNamespace}); err != nil {
+		return fmt.Errorf("failed to list envoyproxies in namespace %s: %w", gcParametersRefNamespace, err)
 	}
 
 	if len(epList.Items) == 0 {
-		r.log.Info("no envoyproxies exist in", "namespace", r.namespace)
+		r.log.Info("no envoyproxies exist in", "namespace", gcParametersRefNamespace)
 		return nil
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1578,14 +1578,14 @@ func (r gatewayAPIReconciler) processParamsRef(ctx context.Context, gc gwapiv1`
`1578`	`1578`	`}`
`1579`	`1579`
`1580`	`1580`	`epList := new(egv1a1.EnvoyProxyList)`
	`1581`	`+ gcParametersRefNamespace := string(*gc.Spec.ParametersRef.Namespace)`
`1581`	`1582`
`1582`		`- // The EnvoyProxy must be in the same namespace as EG.`
`1583`		`- if err := r.client.List(ctx, epList, &client.ListOptions{Namespace: r.namespace}); err != nil {`
`1584`		`- return fmt.Errorf("failed to list envoyproxies in namespace %s: %w", r.namespace, err)`
	`1583`	`+ if err := r.client.List(ctx, epList, &client.ListOptions{Namespace: gcParametersRefNamespace}); err != nil {`
	`1584`	`+ return fmt.Errorf("failed to list envoyproxies in namespace %s: %w", gcParametersRefNamespace, err)`
`1585`	`1585`	`}`
`1586`	`1586`
`1587`	`1587`	`if len(epList.Items) == 0 {`
`1588`		`- r.log.Info("no envoyproxies exist in", "namespace", r.namespace)`
	`1588`	`+ r.log.Info("no envoyproxies exist in", "namespace", gcParametersRefNamespace)`
`1589`	`1589`	`return nil`
`1590`	`1590`	`}`
`1591`	`1591`