Skip to content

Done: Fix the UX of SearchBar & Bottom Nav Bar#156

Merged
aritra-tech merged 5 commits intoaritra-tech:developfrom
dharamveer-gupta:enhancement/fix_ux_of_searchbar_&_bottom_navbar
Oct 18, 2023
Merged

Done: Fix the UX of SearchBar & Bottom Nav Bar#156
aritra-tech merged 5 commits intoaritra-tech:developfrom
dharamveer-gupta:enhancement/fix_ux_of_searchbar_&_bottom_navbar

Conversation

@dharamveer-gupta
Copy link
Copy Markdown
Contributor

@dharamveer-gupta dharamveer-gupta commented Oct 16, 2023

Resolved/Completed below enhancment :-

So, right now when we scroll the nav bar and search bar it sticks to their point but for the betterment of UX, we can do that when we scroll down the column both the nav & search bar gets hidden, and when the user scrolls up it both the nav & search bar should show up.

@dharamveer-gupta dharamveer-gupta mentioned this pull request Oct 16, 2023
Closed
@dharamveer-gupta dharamveer-gupta changed the title Done: Fix the UX of SearchBar & Bottom Nav Bar #148 Done: Fix the UX of SearchBar & Bottom Nav Bar Oct 16, 2023
@aritra-tech
Copy link
Copy Markdown
Owner

aritra-tech commented Oct 16, 2023

Can you please fix the ktlint checks @dharamveer-gupta.

@aritra-tech
Copy link
Copy Markdown
Owner

aritra-tech commented Oct 17, 2023 •
edited
Loading

Still there are 3 issues regarding ktlint @dharamveer-gupta

@dharamveer-gupta
Copy link
Copy Markdown
Contributor Author

dharamveer-gupta commented Oct 17, 2023

Still there are 3 issues regarding ktlint @dharamveer-gupta

Sure, I will look into it

@dharamveer-gupta
Copy link
Copy Markdown
Contributor Author

dharamveer-gupta commented Oct 18, 2023

I have resolved all the ktlint checks, @aritra-tech 👍

aritra-tech
aritra-tech approved these changes Oct 18, 2023
View reviewed changes
Copy link
Copy Markdown
Owner

@aritra-tech aritra-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔

@aritra-tech aritra-tech merged commit 9795ef9 into aritra-tech:develop Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aritra-tech aritra-tech aritra-tech approved these changes

Assignees

@dharamveer-gupta dharamveer-gupta

Labels

features good first issue Good for newcomers hacktoberfest-accepted improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dharamveer-gupta @aritra-tech