Merged
Conversation
# Conflicts: # app/src/main/java/com/aritra/notify/navigation/NotifyApp.kt
Author
|
@aritra-tech merge conflict is resolved now. |
Author
|
Can you please accept this merge reqeuest? |
aritra-tech
added
good first issue
Author
|
@aritra-tech You mentioned you added to the PR. But I don't see it anywhere. Can you please share again over here? |
Owner
I have added a code review, not the PR you can't see the review?
|
Author
|
Yes, I did not receive this notification anywhere in the github. I got the code changes so I will implement them. If possible can you share the link for review here so I can get access to it? |
Author
|
Kindly add reviews that needs to be added over here. I've implemented the changes now @aritra-tech |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added scroll to top when notes item is clicked.