Add keymaps for selecting first/last item#1
Closed
dhth wants to merge 2 commits intoarimxyer:masterfrom
Closed
Conversation
Owner
|
Thanks for the contribution @dhth! 🎉 I've merged your changes with some additions:
Really appreciate you taking the time to submit this - the g/G keymaps and the helper function refactor were great additions! |
arimxyer
added a commit
that referenced
this pull request
Mar 7, 2026
- Add Model Info section with Creator, Source, Region, Type, Released - Source colored green (Open) / red (Closed) - Region and Type use creator category colors from sidebar - Add medal-colored ranks: gold ★ (#1), silver (#2), bronze (#3) - Add ★ Wins summary row near top showing per-model win counts - Pre-compute wins via two-pass to position above metric sections Co-Authored-By: Claude Opus 4.6 <[email protected]>
arimxyer
added a commit
that referenced
this pull request
Mar 19, 2026
Create src/tui/models_app.rs completing the sub-app pattern — Models was the only tab with state on the top-level App struct. Moves 13 fields, 5 types, and 17 methods into ModelsApp. Resolves Known Inconsistency #1 (search_query now lives on sub-app like other tabs). Deduplicate event.rs navigation handling with NavAction enum and parse_nav_key() function. The 4 tab handlers now share a single key-to-action parser, with per-tab resolvers for focus-dependent message dispatch. All edge cases preserved (Benchmarks overlay, Status overall panel, H2H scroll guards). Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
arimxyer
added a commit
that referenced
this pull request
Mar 20, 2026
- Add Model Info section with Creator, Source, Region, Type, Released - Source colored green (Open) / red (Closed) - Region and Type use creator category colors from sidebar - Add medal-colored ranks: gold ★ (#1), silver (#2), bronze (#3) - Add ★ Wins summary row near top showing per-model win counts - Pre-compute wins via two-pass to position above metric sections Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, great tool. Thanks for making it. This PR adds three new key maps:
g: select the first itemG: select the last itemshift-tab: works just liketabfor nowWasn't sure if you wanted these key maps in, but figured it's probably faster to just send a PR rather than creating an issue. Let me know if you'd like something done in a different way. Thanks :)
models.mov