Repository navigation
Commit 1ecfb03
fix(tui):
* fix(tui): `/skills` opens the Altimate skills browser, and its actions work
`/skills` was owned twice: the core prompt's `prompt.skills` (upstream's
plain selector — Enter inserts `/<skill>`, no actions) and the Altimate
plugin's `altimate.skill.list` both registered that slash name, so the
autocomplete listed two `/skills` rows and Enter took the first. Users
were in the plain selector, where ctrl+a is the input's line-home, and
the only TUI route to "Publish to workspace" was unreachable (AltimateAI#1328).
- The core command keeps its palette entry and loses the slash name; the
Altimate browser is `/skills`.
- Enter in the browser now USES the skill — inserts `/<skill> ` into the
prompt, as the docs said and the core selector did. The action picker
is `ctrl+a` and an "Actions" footer button.
- Actions, New and Install are `DialogSelect` actions with in-dialog
bindings (`ctrl+a` / `ctrl+e` / `ctrl+i`) rather than a plugin-level
keymap layer the open dialog outranks; they render as Tab-reachable
footer buttons, so none of them depends on a chord. New is `ctrl+e`
because `ctrl+n` is every dialog's "next". The dialog actions carry
their own command names so the footer labels show the chords that work
there.
- The plugin `DialogSelect` API gains `actions` and `bindings`, forwarded
by the adapter.
- `DialogSelect` computed its action list eagerly, before `selected` was
declared; a function-valued `disabled` (which the browser needs to keep
the synthetic Install row out of the picker) threw "Cannot access
'selected' before initialization". Evaluated lazily now.
Verified under vhs on a local build: the footer reads "Actions ctrl+a ·
New ctrl+e · Install ctrl+i"; Down then ctrl+a opens "Actions:
dbt-pr-review"; Enter on a row leaves "/dbt-pr-review " in the prompt
without submitting. Six tests mount a real DialogSelect in the provider
stack and press the keys (including with the global layer registered
and with a function-valued `disabled`).
Closes AltimateAI#1328
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_012Q51zFUmPg1WwtS5CrGJE6
* fix(tui): bind Install to ctrl+g — ctrl+i is Tab on the wire
Most terminals send ctrl+i as byte 0x09, which the TUI receives as Tab: the
footer's own key. The documented chord could move footer focus instead of
opening Install. ctrl+g is free everywhere in the TUI; the plugin's global
binding and the docs table follow. Test: Tab runs nothing, ctrl+g runs Install.
(bot review on AltimateAI#1342)
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_012Q51zFUmPg1WwtS5CrGJE6
* fix(tui): standalone New/Install, route every Skills entry to the browser, no global ctrl+g
Codex review of AltimateAI#1342 (gpt-5.6-sol).
- `DialogSelect` refused to run any action without a highlighted row, so with
a filter that matched nothing — the create-from-filter flow — ctrl+e and the
New/Install footer buttons did nothing. Actions can be `standalone`
(discriminated union, so every existing row-bound caller types unchanged);
the plugin API and adapter carry it, and New / Install set it
- The core `prompt.skills` command was still a palette row and the target of
a configured `prompt_skills` keybind, both opening the plain selector. It
now dispatches `altimate.skill.list` when that is registered and is hidden
from the palette then, so no route lands on the selector while the browser
exists
- The global ctrl+g binding collided with the session route's `messages_first`;
Install keeps its dialog-local chord only
- `docs/configure/tools/custom.md` still said ctrl+i
- Tests: standalone fires with nothing matching while the row-bound action
does not; the same through the plugin API adapter (a dropped forward fails
it — checked by mutation); Tab then Enter activates the focused footer button
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_012Q51zFUmPg1WwtS5CrGJE6
* test(tui): production command names in the dialog test; exercise the adapter gate
The dialog actions are named `altimate.skill.list.*` as skill-ops declares
them, and the adapter test carries a row-bound action with no `disabled`
function, so the adapter's own gate is what stops it with no row (a
dropped gate fails the test). (bot review)
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_012Q51zFUmPg1WwtS5CrGJE6
* test(tui): the adapter-gate case must use a chord the dialog receives
ctrl+p is the palette outside a dialog and never reached the action, so
the previous no-row assertion was vacuous. ctrl+o instead, with a positive
control that the action fires with a row; disabling the adapter gate now
fails the test.
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_012Q51zFUmPg1WwtS5CrGJE6
---------
Co-authored-by: Claude Opus 5 <[email protected]>/skills opens the Altimate skills browser, and its actions work (AltimateAI#1342)1 parent 4b3b621 commit 1ecfb03
8 files changed
Lines changed: 453 additions & 26 deletions
File tree
- docs/docs/configure
- tools
- packages
- opencode/src/plugin/tui/altimate
- plugin/src
- tui
- src
- component/prompt
- plugin
- ui
- test/ui
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
204 | | - | |
| 204 | + | |
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
208 | 208 | | |
209 | 209 | | |
210 | 210 | | |
211 | 211 | | |
212 | | - | |
213 | 212 | | |
214 | 213 | | |
215 | | - | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
216 | 217 | | |
217 | 218 | | |
218 | | - | |
| 219 | + | |
219 | 220 | | |
220 | 221 | | |
221 | 222 | | |
222 | | - | |
| 223 | + | |
223 | 224 | | |
224 | 225 | | |
225 | 226 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
| 76 | + | |
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
781 | 781 | | |
782 | 782 | | |
783 | 783 | | |
784 | | - | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
| 792 | + | |
| 793 | + | |
| 794 | + | |
785 | 795 | | |
| 796 | + | |
786 | 797 | | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
787 | 839 | | |
788 | 840 | | |
789 | 841 | | |
| |||
884 | 936 | | |
885 | 937 | | |
886 | 938 | | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
887 | 942 | | |
888 | 943 | | |
889 | 944 | | |
890 | 945 | | |
891 | | - | |
892 | 946 | | |
893 | 947 | | |
894 | 948 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
183 | 183 | | |
184 | 184 | | |
185 | 185 | | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
186 | 192 | | |
187 | 193 | | |
188 | 194 | | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
189 | 212 | | |
190 | 213 | | |
191 | 214 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
593 | 593 | | |
594 | 594 | | |
595 | 595 | | |
596 | | - | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
597 | 608 | | |
| 609 | + | |
| 610 | + | |
598 | 611 | | |
599 | 612 | | |
600 | 613 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
2 | 4 | | |
3 | 5 | | |
4 | 6 | | |
| |||
234 | 236 | | |
235 | 237 | | |
236 | 238 | | |
237 | | - | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
238 | 243 | | |
239 | 244 | | |
240 | 245 | | |
| |||
248 | 253 | | |
249 | 254 | | |
250 | 255 | | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
251 | 279 | | |
252 | 280 | | |
253 | 281 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
23 | 36 | | |
24 | 37 | | |
25 | 38 | | |
| |||
35 | 48 | | |
36 | 49 | | |
37 | 50 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
46 | 57 | | |
47 | 58 | | |
48 | 59 | | |
| |||
135 | 146 | | |
136 | 147 | | |
137 | 148 | | |
138 | | - | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
139 | 154 | | |
140 | 155 | | |
141 | | - | |
142 | | - | |
| 156 | + | |
| 157 | + | |
143 | 158 | | |
144 | 159 | | |
145 | 160 | | |
| |||
371 | 386 | | |
372 | 387 | | |
373 | 388 | | |
374 | | - | |
375 | | - | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
376 | 393 | | |
377 | 394 | | |
378 | 395 | | |
| |||
434 | 451 | | |
435 | 452 | | |
436 | 453 | | |
437 | | - | |
438 | | - | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
439 | 458 | | |
440 | 459 | | |
441 | 460 | | |
| |||
0 commit comments