Windows: pass writefds also as exceptfds to select()#975
Closed
Windows: pass writefds also as exceptfds to select()#975
Conversation
winsock notifies connect() failures on exceptfds instead of writefds. Fixes GH-969
tatsuhiro-t
requested changes
Aug 4, 2017
Collaborator
tatsuhiro-t
left a comment
tatsuhiro-t
left a comment
There was a problem hiding this comment.
Other than nits, I think this is ready for merge.
| FD_SET(dummySocket_, &wfdset_); | ||
| fdmax_ = dummySocket_; | ||
| #else // !__MINGW32__ | ||
| #else // __MINGW32__ |
Collaborator
There was a problem hiding this comment.
As far as I know, the convention in aria2 source code is negate condition on "#else". So the original code is right.
It should be // !__MINGW32__
| #endif // !__MINGW32__ | ||
| FD_ZERO(&rfdset_); | ||
| FD_ZERO(&wfdset_); | ||
| #endif // __MINGW32__ |
Collaborator
Author
There was a problem hiding this comment.
uh, clang-format did that...
vijayanandnandam
pushed a commit
to vijayanandnandam/aria2
that referenced
this pull request
Mar 3, 2018
winsock notifies connect() failures on exceptfds instead of writefds. Fixes aria2GH-969 Fixes aria2GH-975
CrackerCat
pushed a commit
to CrackerCat/aria2
that referenced
this pull request
Jul 31, 2024
winsock notifies connect() failures on exceptfds instead of writefds. Fixes aria2GH-969 Fixes aria2GH-975
CrackerCat
pushed a commit
to CrackerCat/aria2
that referenced
this pull request
Aug 1, 2024
winsock notifies connect() failures on exceptfds instead of writefds. Fixes aria2GH-969 Fixes aria2GH-975
CrackerCat
pushed a commit
to CrackerCat/aria2
that referenced
this pull request
Aug 2, 2024
winsock notifies connect() failures on exceptfds instead of writefds. Fixes aria2GH-969 Fixes aria2GH-975
CrackerCat
pushed a commit
to CrackerCat/aria2
that referenced
this pull request
Aug 3, 2024
winsock notifies connect() failures on exceptfds instead of writefds. Fixes aria2GH-969 Fixes aria2GH-975
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-969
@tatsuhiro-t looks good? I added dummysocket to the readfds now too. Shouldn't really make a difference unless readfds is otherwise empty at which point select might have failed sometimes in the past IIRC.