Skip to content

Use latest maven compiler plugin; allow Java 8#93

Closed
grimreaper wants to merge 1 commit intoargparse4j:masterfrom
grimreaper:eax/use_java_8
Closed

Use latest maven compiler plugin; allow Java 8#93
grimreaper wants to merge 1 commit intoargparse4j:masterfrom
grimreaper:eax/use_java_8

Conversation

@grimreaper
Copy link
Copy Markdown
Contributor

@grimreaper grimreaper commented Aug 2, 2017

This allows us to use Java 8 source code in this project.

@jstuyts
Copy link
Copy Markdown
Collaborator

jstuyts commented Aug 2, 2017

You forgot to remove existing source tags in modules main, extensions/hadoop and extensions/java7. Remove those and I will merge.

This allows us to use Java 8 source code in this project without
generating Java 8 bytecode.
@grimreaper
Copy link
Copy Markdown
Contributor Author

hrm, didn't realize that you can't target bytecode older than than the source. Makes sense when I think about it. This now proposes targeting 1.8 in full (and requiring 1.8 JVM).
Its old enough that most projects would be okay with it (hopefully)

@jstuyts
Copy link
Copy Markdown
Collaborator

jstuyts commented Aug 3, 2017

It is possible to use an older target with a newer source, but not the other way around.

There are still people using argparse4j on JDK 6, so we cannot upgrade to JDK 8: #63

We want to be able to set the target JDK per module (1.6 for the core, 1.7 for the Java 7 extension, etc.), but it is fine to set the sources JDK to 1.8 for all modules. Building with 1.8 is also not a problem, and I have a change in the queue that will check that classes from newer JDKs are not used on the CI server: #95

@jstuyts
Copy link
Copy Markdown
Collaborator

jstuyts commented Aug 3, 2017

Because of #95 (which I assume will be merged soon) there is no need to specify the JDK in the Travis file.

@grimreaper grimreaper closed this Aug 4, 2017
@grimreaper grimreaper deleted the eax/use_java_8 branch August 4, 2017 06:12
@jstuyts
Copy link
Copy Markdown
Collaborator

jstuyts commented Aug 4, 2017

I am sorry to see that you decided to revert your changes. The switch to Java 1.8 syntax is not a problem at all, but we must continue to support users that still deploy on Java 1.6. You can create another PR that only changes the source version to 1.8, or else I will make the changes myself soonish.

@grimreaper
Copy link
Copy Markdown
Contributor Author

I plan on making the changes, this PR conflicted in ways that were difficult to recover.
That said, if you get to it first, it will still be cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants