Remove JDK 6 & 7 development dependencies using JDK 9's new javac '--release' flag#125
Merged
jstuyts merged 2 commits intoargparse4j:masterfrom Oct 6, 2020
concision:feat/reduce-jdk-dependencies
Merged
Remove JDK 6 & 7 development dependencies using JDK 9's new javac '--release' flag#125jstuyts merged 2 commits intoargparse4j:masterfrom concision:feat/reduce-jdk-dependencies
jstuyts merged 2 commits intoargparse4j:masterfrom
concision:feat/reduce-jdk-dependencies
Conversation
Collaborator
|
I really don't like that IntelliJ IDEA sets the language level of the Maven modules to Java 9. I have tried to make it so that the correct language level is used, even if that meant that editing for This means that you can use newer language features in the modules, and IntelliJ may even show suggestions for them. These errors will only be caught during a Maven build. I still think this is an improvement, so I will merge it. Maybe an MRJAR with Maven or moving to Gradle will restore the correct language levels for all of the source sets. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a continuation of some of the discussion over at #123, this pull request removes the dependency on JDK6 & 7 installations to successfully compile the project with Maven.
Previously, JDK 6/7 were needed for their
rt.jarinbootclasspathto ensure that no new classes/methods/fields/code above the target language level were accidentally introduced during development, causing potential runtime errors for library users. With the successful merge of #124, JDK 9+ is now required for project compilation, which enables support forjavac's--releaseflag that implements the same functionality without any dependency on JDK 6/7. This feature was not possible in the previous required JDK 8.Impacts:
rt.jarwas removed from JDK 9 and this caused builds to immediately fail with the default properties.