Skip to content

Fix links and clarify the solc-js section#3603

Merged
chriseth merged 2 commits intodevelopfrom
docs-solcjs
Feb 27, 2018
Merged

Fix links and clarify the solc-js section#3603
chriseth merged 2 commits intodevelopfrom
docs-solcjs

Conversation

@axic
Copy link
Contributor

@axic axic commented Feb 26, 2018

No description provided.

`Using the compiler <using-the-compiler.html>` documentation assumes you are using
:ref:`commandline-compiler` documentation assumes you are using
the full-featured compiler, `solc`. So if you install `solcjs` from `npm` then you will
stop reading the documentation here and then continue to <https://github.com/ethereum/solc-js>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph really has to be reworded at some point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but didn't had the motivation yet.

******************************

.. note::
This section doesn't apply to :ref:`solcjs <solcjs>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a big fan of contractions in technical documents...

@chriseth chriseth merged commit bffed2c into develop Feb 27, 2018
@axic axic deleted the docs-solcjs branch February 27, 2018 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants