Skip to content

Normalize paths before using them for lookup key in Standard JSON #2738

@MicahZoltu

Description

@MicahZoltu

Discovered while troubleshooting #2665.

At the moment, global file names aren't normalized before using them as a lookup key when using standard-json. This includes relative paths vs absolute paths and windows separator vs linux separator. I recommend normalizing the keys to absolute path, unix separator (since that works on Windows) before using it as a lookup key rather than using the key as-is. The current behavior can lead to a lot of wasted engineering time debugging as various layers of tooling may use different pathing techniques and the end-user likely expects the lookup to be normalized.

Metadata

Metadata

Assignees

Labels

closed due inactivityThe issue/PR was automatically closed due to inactivity.low impactChanges are not very noticeable or potential benefits are limited.medium effortDefault level of effortneeds designThe proposal is too vague to be implemented right awaystaleThe issue/PR was marked as stale because it has been open for too long.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions