-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Normalize paths before using them for lookup key in Standard JSON #2738
Copy link
Copy link
Closed as not planned
Closed as not planned
Copy link
Labels
closed due inactivityThe issue/PR was automatically closed due to inactivity.The issue/PR was automatically closed due to inactivity.low impactChanges are not very noticeable or potential benefits are limited.Changes are not very noticeable or potential benefits are limited.medium effortDefault level of effortDefault level of effortneeds designThe proposal is too vague to be implemented right awayThe proposal is too vague to be implemented right awaystaleThe issue/PR was marked as stale because it has been open for too long.The issue/PR was marked as stale because it has been open for too long.
Description
Discovered while troubleshooting #2665.
At the moment, global file names aren't normalized before using them as a lookup key when using standard-json. This includes relative paths vs absolute paths and windows separator vs linux separator. I recommend normalizing the keys to absolute path, unix separator (since that works on Windows) before using it as a lookup key rather than using the key as-is. The current behavior can lead to a lot of wasted engineering time debugging as various layers of tooling may use different pathing techniques and the end-user likely expects the lookup to be normalized.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
closed due inactivityThe issue/PR was automatically closed due to inactivity.The issue/PR was automatically closed due to inactivity.low impactChanges are not very noticeable or potential benefits are limited.Changes are not very noticeable or potential benefits are limited.medium effortDefault level of effortDefault level of effortneeds designThe proposal is too vague to be implemented right awayThe proposal is too vague to be implemented right awaystaleThe issue/PR was marked as stale because it has been open for too long.The issue/PR was marked as stale because it has been open for too long.