Fix issues with EXP handling, add testing, add more rules #958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
msooseth
force-pushed
the
dev-pow-product-update
branch
4 times, most recently
from
0ac6cf8 to
6b51cd6
Compare
msooseth
commented
Jan 7, 2026
| Lit 0 -> do | ||
| benc <- exprToSMT b | ||
| pure $ "(ite (= " <> benc `sp` zero <> " ) " <> one `sp` zero <> ")" | ||
| Lit 1 -> pure one |
Collaborator
Author
There was a problem hiding this comment.
Note: I added this here, because while simplify indeed handles special cases, we ALSO have fuzz-testing and I want to be able to fuzz-test, which does NOT use the simplify since we are testing if the simplify is correct :)
msooseth
force-pushed
the
dev-pow-product-update
branch
5 times, most recently
from
62f7e67 to
7bb5b96
Compare
…wModNatural Removing powModNatural Update changelog
msooseth
force-pushed
the
dev-pow-product-update
branch
from
b9a282f to
c2e937e
Compare
blishko
reviewed
Jan 7, 2026
Collaborator
blishko
left a comment
blishko
left a comment
There was a problem hiding this comment.
LGTM!
I think the last line in changelog is unnecessary, no?
Otherwise good to merge!
CHANGELOG.md
Outdated
| - Encode symbolic power of 2 as bit-shift in SMT encoding. | ||
| - Limit the expansion of the EXP operation to avoid blow-up in the size of the SMT expressions. | ||
| - New EXP rewrite rule for base-2 exponents | ||
| - Use `bvshl` in SMT for base-2 exponentiation so we can explore more. |
Collaborator
There was a problem hiding this comment.
I think this refers to the change from the previous PR, no?
It should be covered by Encode symbolic power of 2 as bit-shift in SMT encoding.
Collaborator
Author
There was a problem hiding this comment.
OK, removing last line!
msooseth
force-pushed
the
dev-pow-product-update
branch
from
6cb01a1 to
4e66adf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist