RPC: Small cleanup #923
Merged
RPC: Small cleanup #923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given how withSession is written, the small addresses are going to be handled before we ever reach this point in the code.
In processing query to fetch a slot, the current code checks the cache twice. First directly in the handler code, secondly in function `fetchSlotFrom`. Since this function is not used anywhere else, we inline it and eliminate one unnecessary cache check.
msooseth
approved these changes
Oct 30, 2025
Collaborator
msooseth
left a comment
msooseth
left a comment
There was a problem hiding this comment.
LGTM. Those warnings are reachable, but we probably shouldn't warn about them.
Collaborator
Author
|
I am pretty sure they are unreachable now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In processing query to fetch a slot, the current code checks the cache twice.
First directly in the handler code, secondly in function
fetchSlotFrom.Since this function is not used anywhere else, we inline it and eliminate one unnecessary cache check.
We also remove debug printing that is now actually unreachable.