Also warn on precompile address fetch #913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msooseth
force-pushed
the
Warn-on-precompiled-addresses
branch
from
c284510 to
526460a
Compare
msooseth
changed the title
blishko
reviewed
Oct 28, 2025
Collaborator
blishko
left a comment
blishko
left a comment
There was a problem hiding this comment.
The changes in the tests are unrelated to the changes in the code, no?
Wouldn't it be better to do this in two separate PRs? Or at least in two separate commits.
msooseth
force-pushed
the
Warn-on-precompiled-addresses
branch
from
526460a to
4f178e6
Compare
msooseth
changed the title
Collaborator
Author
|
Fair enough, let me fix! |
Collaborator
Author
|
Fixed now, sorry. New PR opened for the updated tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should warn on precompile addresses? I am not sure whether we should just return 0 without warning, though. Something for Lexi or someone with deep knowledge could perhaps help with.
The tests are also better, it compiles the code rather than giving raw assembly. So it should be easier to follow what's going on.
Checklist