EVM: Separate symbolic and concrete handling of SLOAD #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msooseth
approved these changes
Oct 20, 2025
Collaborator
msooseth
left a comment
msooseth
left a comment
There was a problem hiding this comment.
LGTM, although I'd prefer the small change I suggested :)
blishko
force-pushed
the
execution-refactor
branch
2 times, most recently
from
0ed9b4e to
e37dd34
Compare
Collaborator
Author
|
I had to keep the old behaviour in case the current contract is |
msooseth
approved these changes
Oct 21, 2025
Collaborator
msooseth
left a comment
msooseth
left a comment
There was a problem hiding this comment.
Nice! Maybe you could compact it a bit as per my comment?
This function is needed only in concrete mode and we can simplify it when we know the slot is a concrete value.
blishko
force-pushed
the
execution-refactor
branch
from
e37dd34 to
fa1a99a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up for #903, but this time for SLOAD opcode.
We separate the handling of symbolic and concrete case.
Symbolic case does not case about gas and concrete case can be simpler because it can focus on handling only concrete values.
Moreover, we can specialize
accessStorageForGasfor concrete case, because now it is used only in concrete mode.Checklist