Fix int decoding when upper bits are not set #894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I believe this fix is correct. |
Collaborator
|
@gustavo-grieco , can you test if this still fixes the issue you described in #886? |
Collaborator
Author
|
Just tested the recent changes and all the cases are correctly decoded. |
This test was previously failing as we were decoding signed integers as unsigned and that converting Word256 to Int256 representation. However, if decoding smaller than 256-bit words, this conversion was incorrect.
blishko
force-pushed
the
fix-int-decoding
branch
from
0a9edaa to
3d8f76a
Compare
Collaborator
|
Let me push a changelog line :) |
msooseth
approved these changes
Oct 13, 2025
Collaborator
msooseth
left a comment
msooseth
left a comment
There was a problem hiding this comment.
NICE. I like this bit function, makes it a lot easier to read.
blishko
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for the missing case of #886
Checklist