Fix missing information about concrete Keccak computations #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would lose information about concrete Keccak computations during simplification. This information is then missing when we create constraints on the abstract Keccak computations in the program. The suggested solution is to collect concrete Keccak computations and re-add them to the Props after simplification. We also need to remove the call to simplification in `assertProps`. The propositions are simplified before (in `checkSatWithProps`) and also afterwards, in `assertPropsHelper`. We need to ensure that the concrete Keccak computations survive until they are collected in `assertPropsHelper`.
Closed
msooseth
approved these changes
Oct 6, 2025
Collaborator
msooseth
left a comment
msooseth
left a comment
There was a problem hiding this comment.
Wow. Nice, thanks, that is great. I actually looked quite deep here, and it is indeed right. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would lose information about concrete Keccak computations during simplification.
This information is then missing when we create constraints on the abstract Keccak computations in the program.
The suggested solution is to collect concrete Keccak computations and re-add them to the Props after simplification.
We also need to remove the call to simplification in
assertProps. The propositions are simplified before (incheckSatWithProps) and also afterwards, inassertPropsHelper. We need to ensure that the concrete Keccak computations survive until they are collected inassertPropsHelper.Fixes #819.
Checklist