SMT: Do not return unnecessary information from checkSatWithProps #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msooseth
reviewed
Sep 15, 2025
Collaborator
msooseth
left a comment
msooseth
left a comment
There was a problem hiding this comment.
Wait, wasn't that return value used somewhere? How do we know if something is Partial? I think we used to return some Partial when the SMT couldn't be emitted?
src/EVM/Solvers.hs
Outdated
| let smt2 = assertProps conf psSimp | ||
| if isLeft smt2 then | ||
| let err = getError smt2 in pure (Error err, Left err) | ||
| let err = getError smt2 in pure $ Error err |
Collaborator
There was a problem hiding this comment.
This could be cleaner, also maybe can be on a single line with the if?
src/EVM/Solvers.hs
Outdated
| else do | ||
| res <- liftIO $ checkSat sg (Just props) smt2 | ||
| pure (res, Right (getNonError smt2)) | ||
| liftIO $ checkSat sg (Just props) smt2 |
Collaborator
There was a problem hiding this comment.
Maybe on a single line with the else? Also we can then remove the do
It turns out no one was actually using this information anyway and there is no reason to keep the SMT-LIB script around.
blishko
force-pushed
the
smt-refactor-part3
branch
from
6f3a9fd to
711d885
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out no one was actually using this information anyway and there is no reason to keep the SMT-LIB script around.
Checklist