Skip to content

Bump dependency upper bounds #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
msooseth merged 1 commit into from
Sep 5, 2025
Merged

Bump dependency upper bounds #846

msooseth merged 1 commit into from
Sep 5, 2025

Conversation

@elopez
Copy link
Collaborator

@elopez elopez commented Sep 3, 2025

Description

See NixOS/nixpkgs@62423a6

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@elopez
Copy link
Collaborator Author

elopez commented Sep 4, 2025

Tested with this on our pinned nixpkgs and it builds fine

diff --git a/flake.nix b/flake.nix
index 00426dc2..ad2cf090 100644
--- a/flake.nix
+++ b/flake.nix
@@ -51,14 +51,9 @@
         }));

         hspkgs = ps :
-          ps.haskellPackages.override {
+          ps.haskell.packages.ghc910.override {
             overrides = hfinal: hprev: {
-              with-utf8 =
-                if (with ps.stdenv; hostPlatform.isDarwin && hostPlatform.isx86)
-                then ps.haskell.lib.compose.overrideCabal (_ : { extraLibraries = [ps.libiconv]; }) hprev.with-utf8
-                else hprev.with-utf8;
-              # TODO: temporary fix for static build which is still on 9.4
-              witch = ps.haskell.lib.doJailbreak hprev.witch;
+              aeson-optics = ps.haskell.lib.doJailbreak hprev.aeson-optics;
             };
           };
         hlib = pkgs.haskell.lib;

just a few warnings with 9.10:

[ 4 of 29] Compiling EVM.Types        ( src/EVM/Types.hs, dist-newstyle/build/aarch64-osx/ghc-9.10.2/hevm-0.55.1/build/EVM/Types.o, dist-newstyle/build/aarch64-osx/ghc-9.10.2/hevm-0.55.1/build/EVM/Types.dyn_o ) [dist-newstyle/build/aarch64-osx/ghc-9.10.2/hevm-0.55.1/build/autogen/cabal_macros.h changed]
src/EVM/Types.hs:28:1: warning: [GHC-66111] [-Wunused-imports]
    The import of ‘Data.List’ is redundant
      except perhaps to import instances from ‘Data.List’
    To import instances alone, use: import Data.List()
   |
28 | import Data.List (foldl')
   | ^^^^^^^^^^^^^^^^^^^^^^^^^

[ 5 of 29] Compiling EVM.Traversals   ( src/EVM/Traversals.hs, dist-newstyle/build/aarch64-osx/ghc-9.10.2/hevm-0.55.1/build/EVM/Traversals.o, dist-newstyle/build/aarch64-osx/ghc-9.10.2/hevm-0.55.1/build/EVM/Traversals.dyn_o )
src/EVM/Traversals.hs:12:1: warning: [GHC-66111] [-Wunused-imports]
    The import of ‘Data.List’ is redundant
      except perhaps to import instances from ‘Data.List’
    To import instances alone, use: import Data.List()
   |
12 | import Data.List (foldl')
   | ^^^^^^^^^^^^^^^^^^^^^^^^^

[24 of 29] Compiling EVM.Fetch        ( src/EVM/Fetch.hs, dist-newstyle/build/aarch64-osx/ghc-9.10.2/hevm-0.55.1/build/EVM/Fetch.o, dist-newstyle/build/aarch64-osx/ghc-9.10.2/hevm-0.55.1/build/EVM/Fetch.dyn_o )
src/EVM/Fetch.hs:21:1: warning: [GHC-66111] [-Wunused-imports]
    The import of ‘Data.List’ is redundant
      except perhaps to import instances from ‘Data.List’
    To import instances alone, use: import Data.List()
   |
21 | import Data.List (foldl')
   | ^^^^^^^^^^^^^^^^^^^^^^^^^

[27 of 29] Compiling EVM.SymExec      ( src/EVM/SymExec.hs, dist-newstyle/build/aarch64-osx/ghc-9.10.2/hevm-0.55.1/build/EVM/SymExec.o, dist-newstyle/build/aarch64-osx/ghc-9.10.2/hevm-0.55.1/build/EVM/SymExec.dyn_o )
src/EVM/SymExec.hs:18:19: warning: [GHC-38856] [-Wunused-imports]
    The import of ‘foldl'’ from module ‘Data.List’ is redundant
   |
18 | import Data.List (foldl', sortBy, sort)
   |                   ^^^^^^

[28 of 29] Compiling EVM.UnitTest     ( src/EVM/UnitTest.hs, dist-newstyle/build/aarch64-osx/ghc-9.10.2/hevm-0.55.1/build/EVM/UnitTest.o, dist-newstyle/build/aarch64-osx/ghc-9.10.2/hevm-0.55.1/build/EVM/UnitTest.dyn_o )
src/EVM/UnitTest.hs:22:1: warning: [GHC-66111] [-Wunused-imports]
    The import of ‘Data.List’ is redundant
      except perhaps to import instances from ‘Data.List’
    To import instances alone, use: import Data.List()
   |
22 | import Data.List (foldl')
   | ^^^^^^^^^^^^^^^^^^^^^^^^^

@elopez elopez marked this pull request as ready for review September 4, 2025 12:57
@blishko
Copy link
Collaborator

blishko commented Sep 4, 2025

I was about to ask if we can test somehow that hevm still works fine with the updated dependencies.
Do we need to test the static build? I guess we can merge, @msooseth?

@msooseth
Copy link
Collaborator

msooseth commented Sep 5, 2025

Yep, it passes, so we can just merge :)

@msooseth msooseth merged commit a6ea7f1 into main Sep 5, 2025
7 checks passed
@msooseth msooseth deleted the dep-bump branch September 5, 2025 13:15
@msooseth
Copy link
Collaborator

msooseth commented Sep 5, 2025

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elopez @blishko @msooseth