SMT: Avoid unnecessary allocations during Expr translation #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blishko
force-pushed
the
make-write-bytes-more-efficient
branch
2 times, most recently
from
b1251ce to
dfc7a4d
Compare
In writeBytes, there is no need to unpack bytestring into a list in order to fold it. Also, we don't have to call `exprToSMT` to translate index and byte into a bitvector. Thus, `wrap` can be pure. Similarly, when translating literals, we can also directly translate the value, without unnecessary conversion.
blishko
force-pushed
the
make-write-bytes-more-efficient
branch
from
dfc7a4d to
fba55d0
Compare
msooseth
approved these changes
Sep 8, 2025
Collaborator
msooseth
left a comment
msooseth
left a comment
There was a problem hiding this comment.
Oh, this is really nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously,
exprToSMTandwriteByteswere creating unnecessary temporary structures for processing numbers and bytestrings. However, Haskell libraries offer a way to process these directly.Checklist