Fixing RPC fetching and reading of slots, adding mocking to RPC for testing #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msooseth
force-pushed
the
fix-value-getting
branch
from
bfa060b to
0890216
Compare
Improve I see no reason why these should fail More explanations
msooseth
force-pushed
the
fix-value-getting
branch
from
6de8cd6 to
783d6de
Compare
Collaborator
|
Is this affecting concrete execution as well? |
Collaborator
Author
It should not be, AFAIK. Also, I still need to refine this, some tests are failing. |
msooseth
changed the title
msooseth
force-pushed
the
fix-value-getting
branch
from
f311356 to
228e151
Compare
Update Update No need Update for block too Finally working Update Adding test Update Update Update for debug Update These are expected to fail Clean Fixing RPC
msooseth
force-pushed
the
fix-value-getting
branch
from
25fa9c5 to
a942706
Compare
msooseth
force-pushed
the
fix-value-getting
branch
from
7b39444 to
b535bbb
Compare
msooseth
commented
Sep 1, 2025
Comment on lines
+1434
to
+1436
| Just (Lit _) -> continue x | ||
| Just _ | not c.external -> continue x | ||
| _ -> rpcCall c slotConc |
Collaborator
Author
There was a problem hiding this comment.
Basically, the issue here was, that the readStorage would return a Just (SLoad...) in some cases, which is wrong -- it actually didn't find the concrete storage, and the data may not have been retrieved from RPC.
blishko
reviewed
Sep 8, 2025
msooseth
commented
Sep 8, 2025
Collaborator
Author
msooseth
left a comment
msooseth
left a comment
There was a problem hiding this comment.
Thanks! Yesss, I have now fixed some of these. Let me go through once more.
Co-authored-by: blishko <[email protected]>
msooseth
force-pushed
the
fix-value-getting
branch
from
cf69009 to
a12c044
Compare
No need to update this test No need for this change
msooseth
force-pushed
the
fix-value-getting
branch
from
a12c044 to
6b775ed
Compare
Collaborator
Author
|
OK, I tried to go through one more time, and I cleaned up this PR. Should be a little easier on the eyes now :) |
blishko
approved these changes
Sep 9, 2025
Collaborator
blishko
left a comment
blishko
left a comment
There was a problem hiding this comment.
Let's go ahead with this one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a bug with RPC not fetching data. The fix for this was that in case the contract is remote, check the underlying concrete storage directly to see if the value has already been fetched. If not, then fetch it. It's a relatively simple, straightforward code change.
The more complex part of this PR is that I added a test framework for creating and using mock data for RPC, so we can create and replay RPC call data for proper testing. When in
--debugmode, all RPC data is written to JSON files. These can then be collated together with a python script. I used python because it's only to be used by developers, so it doesn't need to be present and exposed in nix, etc.Fixes #757
Checklist