Solidity: Refactor reading standard JSON from solc #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blishko
force-pushed
the
standard-json-reading-cleanup
branch
from
6ababb4 to
eb77571
Compare
msooseth
reviewed
Aug 11, 2025
Collaborator
msooseth
left a comment
msooseth
left a comment
There was a problem hiding this comment.
Nice! So this should improve our error handling :)
We refactor the method readStdJSON so that it can better propagate errors, similar to other JSON reading functions. To enable that we introduce a datatype to represent the contract data in the JSON representation. This simplifies JSON parsing significantly, because we can rely on Aeson to do the heavy lifting, for the most part. Additionally, we change the return type to only `Contracts`, since this is the only part that callers were interested in. We do not try to construct Asts and Sources anymore. We should probably not export the function at all and keep it internal.
blishko
force-pushed
the
standard-json-reading-cleanup
branch
from
eb77571 to
3ce69f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We refactor the method
readStdJSONso that it can better propagate errors, similar to other JSON reading functions.To enable that we introduce a datatype to represent the contract data in the JSON representation. This simplifies JSON parsing significantly, because we can rely on Aeson to do the heavy lifting, for the most part.
Additionally, we change the return type to only
Contracts, since this is the only part that callers were interested in. We do not try to construct Asts and Sources anymore.We should probably not export the function at all and keep it internal.
Checklist