Skip to content

Optimize word256Bytes, word160Bytes #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
msooseth merged 2 commits into from
Jul 30, 2025
Merged

Optimize word256Bytes, word160Bytes #808

msooseth merged 2 commits into from
Jul 30, 2025

Conversation

@elopez
Copy link
Collaborator

@elopez elopez commented Jul 26, 2025

Description

This optimizes these two functions with direct bytestring construction. It also adds differential testing against the previous implementations.

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@elopez
Copy link
Collaborator Author

elopez commented Jul 26, 2025

I see concrete exec improvements in arrayCreationMem and more generally on MSTORE-heavy execution.

  arrayCreationMem
    2:   OK
      374  μs ±  26 μs,  7% less than baseline
    4:   OK
      925  μs ±  34 μs, 13% less than baseline
    8:   OK
      3.26 ms ± 271 μs,  9% less than baseline
    16:  OK
      11.6 ms ± 1.0 ms, 10% less than baseline
    32:  OK
      45.4 ms ± 4.2 ms,  9% less than baseline
    64:  OK
      177  ms ± 6.8 ms, 10% less than baseline
    128: OK
      697  ms ±  55 ms,  9% less than baseline
    256: OK
      2.773 s ±  36 ms, 11% less than baseline
    512: OK
      11.085 s ± 108 ms,  8% less than baseline

@gustavo-grieco gustavo-grieco mentioned this pull request Jul 28, 2025
Closed
4 tasks
@msooseth
Copy link
Collaborator

msooseth commented Jul 28, 2025

@gustavo-grieco if you could also review & merge, that'd be great! LGTM :)

msooseth
msooseth approved these changes Jul 28, 2025
View reviewed changes
Copy link
Collaborator

@msooseth msooseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'd prefer to have a CHANGELOG update, too :)

gustavo-grieco
gustavo-grieco approved these changes Jul 30, 2025
View reviewed changes
Copy link
Collaborator

@gustavo-grieco gustavo-grieco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Let's make an issue to eventually remove the old code, and all its dependencies.

elopez and others added 2 commits July 30, 2025 11:22
@elopez @msooseth
Optimize word256Bytes, word160Bytes
3d2ebd8 
This optimizes these two functions with direct bytestring construction. It
also adds differential testing against the previous implementations.
@msooseth
Adding line to changelog
50f68c9
@msooseth msooseth merged commit f8484a4 into main Jul 30, 2025
8 checks passed
@msooseth msooseth deleted the word2bytestring branch July 30, 2025 09:23
@msooseth
Copy link
Collaborator

msooseth commented Jul 30, 2025

Thanks all!! I rebased and merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gustavo-grieco gustavo-grieco gustavo-grieco approved these changes

@msooseth msooseth msooseth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elopez @msooseth @gustavo-grieco