Allow dealing with abi.encodeWithSelector #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
msooseth
commented
Jan 2, 2025
| JumpIntoSymbolicCode pc idx -> "Encountered a jump into a potentially symbolic code region while executing initcode. pc: " <> pack (show pc) <> " jump dst: " <> pack (show idx) | ||
|
|
||
| formatSomeExpr :: SomeExpr -> Text | ||
| formatSomeExpr (SomeExpr e) = formatExpr e |
Collaborator
Author
There was a problem hiding this comment.
I added this change, because it's waaay nicer for the user, and we should be getting cleaner issues, too.
msooseth
force-pushed
the
func-selector-fix
branch
from
94c5567 to
e5f26f1
Compare
Collaborator
Author
|
NOTE: This is failing currently only because #619 is not yet merged :) |
msooseth
force-pushed
the
func-selector-fix
branch
from
d1a6f02 to
f306e9c
Compare
msooseth
force-pushed
the
func-selector-fix
branch
from
f306e9c to
94a618e
Compare
blishko
reviewed
Jan 6, 2025
Comment on lines
+1438
to
+1439
| indexWord (Lit a) (Or funSel (And (Lit 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffff) _)) | a < 4 = | ||
| indexWord (Lit a) funSel |
Collaborator
There was a problem hiding this comment.
Do I understand it correctly that this simplification is correct because the four most significant bytes of (And (Lit 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffff) _) will always be zero?
Collaborator
Author
|
Yes! :)
…On Mon 6. Jan 2025 at 15:45, Martin Blicha ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/EVM/Expr.hs
<#625 (comment)>:
> +indexWord (Lit a) (Or funSel (And (Lit 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffff) _)) | a < 4 =
+ indexWord (Lit a) funSel
Do I understand it correctly that this simplification is correct because
the four most significant bytes of (And (Lit
0xffffffffffffffffffffffffffffffffffffffffffffffffffffffff) _) will
always be zero?
—
Reply to this email directly, view it on GitHub
<#625 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXYLY5GV2F7AG2LNPTSDS2T2JKJHTAVCNFSM6AAAAABUQFWJU6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMZSGI4TINJRGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This helps to deal with
abi.encodeWithSelector. Adds a corresponding simplification rules.Fixes the test case added:
Meant to be used together with #619 and works only on top of #619
Checklist