docs: replace the MinIO Helm install with the quick-start S3 server by fjvbn2003 · Pull Request #17246 · argoproj/argo-workflows

fjvbn2003 · 2026-10-16T15:50:38Z

See the pull request guide for details on each item.

Ran make pre-commit -B
Signed-off commits with Conventional Commit messages
PR title is a conventional commit message (it becomes the release notes entry)
Unit or e2e tests cover the change
For features: an associated issue and a feature description file (make feature-new)
Opened as draft; will mark "Ready for review" once builds are green

Related to #17030 (the quick-start part was fixed in #17073)

Motivation

The "Configuring MinIO" section of docs/configure-artifact-repository.md still tells readers to run helm install argo-artifacts minio/minio from https://charts.min.io/. If you copy the command as written, it fails in three ways:

The chart (5.4.0, from the archived minio/minio repository) defaults to quay.io/minio/minio:RELEASE.2024-12-18T13-15-44Z and quay.io/minio/mc:RELEASE.2024-11-21T17-21-54Z. Both manifests now return 401 UNAUTHORIZED with an anonymous pull token, and docker.io/minio/minio returns 404, so the pods stay in ImagePullBackOff.
helm template with the documented flags renders a StatefulSet with replicas: 16, and each pod requests memory: 16Gi. That is far too large for the test setup this section describes.
The credential commands read .data.accesskey and .data.secretkey, but the chart's Secret has the keys rootUser and rootPassword, so both commands print nothing. The section also says the UI is on port 9000. The chart serves the console on 9001, through the argo-artifacts-console Service.

#17073 already moved the quick-start MinIO to pgsty/silo.

Modifications

The section now installs the quick-start MinIO component, pinned to v4.1.5 with kubectl apply -k. The component already contains pgsty/silo, the my-bucket bucket and the my-minio-cred Secret with the accesskey/secretkey keys that artifact-repository-ref.md uses. The section states that the component is for testing only (fixed credentials, no persistent volume) and shows how to reach the console on 9001. The TLS paragraph after it is unchanged.

Verification

Anonymous pulls, checked against the registry API on 2026-10-17: quay.io/v2/minio/minio/manifests/RELEASE.2024-12-18T13-15-44Z and quay.io/v2/minio/mc/manifests/RELEASE.2024-11-21T17-21-54Z return 401. hub.docker.com/v2/repositories/minio/minio/ returns 404. docker.io/pgsty/silo:RELEASE.2026-09-16T00-00-00Z resolves (about 54 MiB compressed, amd64).
helm template argo-artifacts <minio chart 5.4.0> --set service.type=LoadBalancer --set fullnameOverride=argo-artifacts (Helm v3.18.2) renders kind: StatefulSet, replicas: 16, requests.memory: 16Gi, a Secret with rootUser/rootPassword only, and the console Service on port 9001.
kustomize build manifests/quick-start/base/minio renders the Secret my-minio-cred (accesskey, secretkey), the Service minio (9000/9001) and the Deployment with the pgsty/silo image. manifests/quick-start/base/minio/minio-deploy.yaml at v4.1.5 contains the same image.
I did not apply the component to a cluster for this PR. The quick-start e2e runs it.

Documentation

This PR changes documentation only.

AI

I used an AI assistant to draft the text and the commit message. I checked the registry responses, the rendered chart and the kustomize output myself, as listed under Verification.

This change was drafted with AI assistance and reviewed by me.

🤖 Generated with Claude Code

Summary by CodeRabbit

Documentation
- Updated the artifact repository setup guide to use a quick-start S3-compatible server deployment.
- Added details about its ports, credentials, storage, created resources, and web-console access.
- Clarified that the setup is not intended for production use.
- Replaced the previous Helm-based installation, credential retrieval, and manual bucket-creation steps.

github-actions · 2026-10-16T15:53:28Z

✅ PR readiness: all clear

All contributor-fixable checks are passing. A maintainer will take it from here — thanks!

_{🤖 Automated PR-readiness helper — it re-checks each time CI finishes. Unit/E2E test results are not covered here. Questions? See the contributing guide or ask a maintainer.}

The MinIO section installed the chart from charts.min.io. That chart is archived, its default images on quay.io now return 401 for anonymous pulls, and its defaults render a 16-replica StatefulSet that requests 16Gi of memory per pod. The credential commands also read the keys accesskey and secretkey, but the chart's Secret uses rootUser and rootPassword. Point readers to the MinIO component of the quick-start manifests, which already runs pgsty/silo and creates my-minio-cred with the keys that artifact-repository-ref.md expects. Signed-off-by: YoungjuKim <[email protected]>

coderabbitai · 2026-10-16T16:08:12Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: argoproj/argo-workflows/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: b72cc653-df1d-49d5-8666-67f3076b215a

📥 Commits

Reviewing files that changed from the base of the PR and between fb791c8 and 11ae332.

📒 Files selected for processing: 1

docs/configure-artifact-repository.md

🚧 Files skipped from review as they are similar to previous changes: 1

docs/configure-artifact-repository.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The artifact repository guide replaces Helm-based MinIO setup instructions with instructions for deploying and accessing the Silo quick-start server. The spell-checker word list adds pgsty.

Changes: MinIO test setup

Layer / File(s)	Summary
Document quick-start deployment and access `docs/configure-artifact-repository.md`, `.cspell.json`	The guide documents the Silo quick-start deployment, its resources, credentials, storage, and console access. The spell-checker word list adds `pgsty`.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: sule26, joibel

Merge Risk: ⚪ Minimal · up to 11ae3

The documented test setup has no identified merge-blocking issue. The pinned remote manifest was not independently checked.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: replacing the documented MinIO Helm installation with the quick-start S3 server.
Description check		The description covers the motivation, modifications, verification, documentation, and AI use. It also reports that pre-commit was not run and tests were not added, so those unchecked items are clear …
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description covers the motivation, modifications, verification, documentation, and AI use. It also reports that pre-commit was not run and tests were not added, so those unchecked items are clear rather than unexplained omissions.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

🔇 Additional comments: 2

.cspell.json: 1

93-94: LGTM!
docs/configure-artifact-repository.md-107-107: 1
107-107: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Hyphenate S3-compatible.

Change “S3 compatible server” to “S3-compatible server.” The static analysis hint flags the missing hyphen.
Proposed wording
-For a test setup, you can install the S3 compatible server that the [quick start](quick-start.md) uses.
+For a test setup, you can install the S3-compatible server that the [quick start](quick-start.md) uses.
Source: Linters/SAST tools

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: argoproj/argo-workflows/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: ea5eb548-fb28-4698-a9f6-9bf64c4179c1

📥 Commits

Reviewing files that changed from the base of the PR and between f40f8dc and fb791c8.

📒 Files selected for processing: 2

.cspell.json
docs/configure-artifact-repository.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Joibel · 2026-10-20T08:37:18Z


-You can install MinIO into your cluster via Helm.
+MinIO no longer publishes community container images.
+The MinIO Helm chart at `https://charts.min.io/` is archived, and its default images (`quay.io/minio/minio` and `quay.io/minio/mc`) can no longer be pulled without credentials.


This information isn't relevant to anyone reading this page for the first time- please reword the page for a first time reader, please don't tell a story from "how things used to be", that just confuses users..

Thanks, makes sense. I removed the background paragraph so the section starts with what to install for a test setup.

Drop the background on why the Helm chart is no longer suggested, as requested in review, and start the section with what to install. Assisted-by: Claude <[email protected]> Signed-off-by: YoungjuKim <[email protected]>

argo-cd-cherry-pick-bot · 2026-10-26T11:33:20Z

🍒 Cherry-pick PR created for 4.1: #17298

argo-cd-cherry-pick-bot · 2026-10-26T11:33:21Z

❌ Cherry-pick failed for 4.0. Please check the workflow logs for details.

…cherry-pick #17246 for 4.1) (#17298) Signed-off-by: YoungjuKim <[email protected]> Co-authored-by: Youngju KIM <[email protected]>

…cherry-pick #17246 for 4.0) (#17299) Signed-off-by: YoungjuKim <[email protected]> Signed-off-by: Alan Clucas <[email protected]> Co-authored-by: Youngju KIM <[email protected]>

fjvbn2003 requested review from a team as code owners October 16, 2026 15:50

github-actions Bot added the problem/bot-not-ready Readiness bot declares this as not ready, see comment by bot for why label Oct 16, 2026

fjvbn2003 force-pushed the docs-artifact-repo-quickstart-s3 branch from 1e122e2 to fb791c8 Compare October 16, 2026 15:56

github-actions Bot removed the problem/bot-not-ready Readiness bot declares this as not ready, see comment by bot for why label Oct 16, 2026

coderabbitai Bot reviewed Oct 16, 2026

View reviewed changes

Joibel requested changes Oct 20, 2026

View reviewed changes

docs: describe the MinIO test setup for a first-time reader

11ae332

Drop the background on why the Helm chart is no longer suggested, as requested in review, and start the section with what to install. Assisted-by: Claude <[email protected]> Signed-off-by: YoungjuKim <[email protected]>

tico24 approved these changes Oct 26, 2026

View reviewed changes

Joibel approved these changes Oct 26, 2026

View reviewed changes

Joibel merged commit 750c81f into argoproj:main Oct 26, 2026
19 checks passed

Joibel added cherry-pick/4.0 Cherry-pick this to release-4.0 cherry-pick/4.1 Cherry pick this to release-4.1 labels Oct 26, 2026

argo-cd-cherry-pick-bot Bot mentioned this pull request Oct 26, 2026

docs: replace the MinIO Helm install with the quick-start S3 server (cherry-pick #17246 for 4.1) #17298

Merged

Joibel pushed a commit that referenced this pull request Oct 26, 2026

docs: replace the MinIO Helm install with the quick-start S3 server (…

1c866a5

…cherry-pick #17246 for 4.1) (#17298) Signed-off-by: YoungjuKim <[email protected]> Co-authored-by: Youngju KIM <[email protected]>

Joibel mentioned this pull request Oct 26, 2026

docs: replace the MinIO Helm install with the quick-start S3 server (cherry-pick #17246 for 4.0) #17299

Merged

Navigation Menu

Repository navigation

docs: replace the MinIO Helm install with the quick-start S3 server - #17246

docs: replace the MinIO Helm install with the quick-start S3 server#17246
Joibel merged 2 commits into
argoproj:mainfrom
fjvbn2003:docs-artifact-repo-quickstart-s3

fjvbn2003 commented Oct 16, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

github-actions Bot commented Oct 16, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 16, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Joibel Oct 20, 2026

Uh oh!

fjvbn2003 Oct 20, 2026

Uh oh!

Uh oh!

argo-cd-cherry-pick-bot Bot commented Oct 26, 2026

Uh oh!

argo-cd-cherry-pick-bot Bot commented Oct 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

fjvbn2003 commented Oct 16, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Modifications

Verification

Documentation

AI

Summary by CodeRabbit

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ PR readiness: all clear

Uh oh!

coderabbitai Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Joibel Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

fjvbn2003 Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

argo-cd-cherry-pick-bot Bot commented Oct 26, 2026

Uh oh!

argo-cd-cherry-pick-bot Bot commented Oct 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fjvbn2003 commented Oct 16, 2026 •

edited by coderabbitai Bot

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

coderabbitai Bot commented Oct 16, 2026 •

edited

Loading