Skip to content

Fixed short-path tests. #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmaglie merged 2 commits into from
Jun 10, 2025
Merged

Fixed short-path tests. #38

cmaglie merged 2 commits into from
Jun 10, 2025

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented May 30, 2025 •
edited
Loading

The failing CI is due to the GitHub runners not supporting short paths.

On my local Windows machine:

=== RUN   TestEquivalentPaths
     paths_test.go:343: SHORTENED PATH: testdata\fileset\ANOTHE~1
--- PASS: TestEquivalentPaths (0.00s)
=== RUN   TestCanonicalize
     paths_test.go:361: SHORTENED PATH: testdata\fileset\ANOTHE~1
--- PASS: TestCanonicalize (0.00s)

On GitHub CI:

=== RUN   TestEquivalentPaths
    paths_test.go:343: SHORTENED PATH: testdata\fileset\anotherFile
--- PASS: TestEquivalentPaths (0.00s)
=== RUN   TestCanonicalize
    paths_test.go:361: SHORTENED PATH: testdata\fileset\anotherFile
--- PASS: TestCanonicalize (0.00s)

@cmaglie cmaglie force-pushed the shorten-path-test-improve branch from a2c0ec1 to bc69599 Compare May 30, 2025 09:46
@cmaglie cmaglie marked this pull request as ready for review June 10, 2025 07:09
@cmaglie cmaglie requested a review from a team June 10, 2025 07:09
@cmaglie cmaglie merged commit 33adc4f into master Jun 10, 2025
7 checks passed
@cmaglie cmaglie deleted the shorten-path-test-improve branch June 10, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alessio-perugini alessio-perugini alessio-perugini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmaglie @alessio-perugini