Skip to content

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented May 10, 2023

This PR should revert the breaking change in 1.9.0, we should tag the release 1.9.1 after merging this one.

@cmaglie cmaglie self-assigned this May 10, 2023
@cmaglie cmaglie linked an issue May 10, 2023 that may be closed by this pull request
@cmaglie cmaglie added type: bug Perceived defect in any part of project topic: code Related to content of the project itself labels May 10, 2023
@cmaglie
Copy link
Member Author

cmaglie commented May 10, 2023

We may also release a v2 version, and keep the API breaking change, but this will force consumers of this library to update their import path to:

github.com/arduino/go-paths-helper/v2

I don't think it's worth it.

@cmaglie cmaglie merged commit 7d88805 into master May 10, 2023
@cmaglie cmaglie deleted the restore-1.x-compatibility branch May 19, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: code Related to content of the project itself type: bug Perceived defect in any part of project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breaking change to github.com/arduino/go-paths-helper.Path.IsInsideDir

2 participants