-
-
Notifications
You must be signed in to change notification settings - Fork 2
Closed
Labels
conclusion: resolvedIssue was resolvedIssue was resolvedtopic: documentationRelated to documentation for the projectRelated to documentation for the projecttype: bugPerceived defect in any part of projectPerceived defect in any part of project
Description
One of the result parameters parameters was removed from the github.com/arduino/go-paths-helper.Path.IsInsideDir method in 657985f
The breaking change to the package API is reasonable, but it was not communicated to the module's users.
I suggest the following remediation measures:
- Make a 2.0.0 release (as advised here)
- Document the breaking change in the 2.0.0 release notes
Metadata
Metadata
Assignees
Labels
conclusion: resolvedIssue was resolvedIssue was resolvedtopic: documentationRelated to documentation for the projectRelated to documentation for the projecttype: bugPerceived defect in any part of projectPerceived defect in any part of project