.changeset/solid-loops-feel.md (1)

1-18: Clarify behavior and precedence in the changeset.
Consider explicitly documenting:

• Alias resolution now occurs before absolute/path checks.
• Precedence between predefinedImports and pathAliases (ideally, predefinedImports should win to preserve virtual imports).

Proposed wording tweak:

 The solution is straightforward: move path alias resolution before the absolute path check instead of after it.
+Precedence note: virtual imports provided via `predefinedImports` should take priority over alias rewriting to avoid surprising lookups when a virtual key also matches an alias pattern.

packages/import/src/index.ts (1)

683-709: Match TS “paths” selection order and minor robustness in alias resolution.
Today, the first mapping that matches wins. TypeScript prefers:

• Exact patterns over wildcard patterns.
• Among wildcards, longer prefixes first.
  Also, handle absolute mapped targets without resolveFrom.

Apply this diff:

-function applyPathAliases(filePath: string, pathAliases?: PathAliases): string {
+function applyPathAliases(filePath: string, pathAliases?: PathAliases): string {
   if (pathAliases == null) {
     return filePath;
   }
 
-  for (const [prefixPattern, mapping] of Object.entries(pathAliases.mappings)) {
+  const entries = Object.entries(pathAliases.mappings).sort((a, b) => {
+    const [ak, bk] = [a[0], b[0]];
+    const aWild = ak.includes('*') ? 1 : 0;
+    const bWild = bk.includes('*') ? 1 : 0;
+    if (aWild !== bWild) return aWild - bWild; // exact before wildcard
+    const aLen = ak.includes('*') ? ak.indexOf('*') : ak.length;
+    const bLen = bk.includes('*') ? bk.indexOf('*') : bk.length;
+    return bLen - aLen; // longer prefix first
+  });
+
+  for (const [prefixPattern, mapping] of entries) {
     const matchedMapping = applyPathAlias(prefixPattern, mapping, filePath);
     if (matchedMapping == null) {
       continue;
     }
 
-    const resolvedMapping = resolveFrom(pathAliases.rootDir ?? process.cwd(), matchedMapping);
-    return realpathSync(resolvedMapping);
+    const baseDir = pathAliases.rootDir ?? process.cwd();
+    const target = isAbsolute(matchedMapping)
+      ? matchedMapping
+      : resolveFrom(baseDir, matchedMapping);
+    return realpathSync(target);
   }
 
   return filePath;
 }

packages/import/tests/schema/import-schema.spec.ts (2)

1294-1307: DRY up repeated expected SDL across the two new tests

The expected SDL is identical in both tests. Consider a small constant to reduce duplication and ease future edits.

Add this helper near the top of the describe block (or right above these tests):

const expectedAWithB = /* GraphQL */ `
  type Query {
    getA: TypeA
  }

  type TypeA {
    id: ID!
    relatedB: TypeB!
  }

  type TypeB {
    id: ID!
  }
`;

Then update both assertions:

-    expect(document).toBeSimilarGqlDoc(/* GraphQL */ `
-      type Query {
-        getA: TypeA
-      }
-
-      type TypeA {
-        id: ID!
-        relatedB: TypeB!
-      }
-
-      type TypeB {
-        id: ID!
-      }
-    `);
+    expect(document).toBeSimilarGqlDoc(expectedAWithB);

Also applies to: 1321-1334

---

1310-1311: Rename for clarity

Consider tightening the test name to: "should handle node-style subpath import aliases".

-it('should handle node-style subpath imports path aliases', () => {
+it('should handle node-style subpath import aliases', () => {

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

packages/import/src/index.ts (1)

175-180: Predefined-import precedence preserved; absolute aliases now resolved early — LGTM.

Moving aliasing ahead of the absolute-path check while skipping predefinedImports fixes the bug without breaking virtual imports. Good call.

packages/import/src/index.ts (2)

672-683: Consider extension fallbacks for local schema files.

Optional: before falling back to resolveFrom, try .graphql/.gql variants when the direct joined path isn’t found. This helps common extensionless specifiers in repos that keep GraphQL next to code.

-function resolveFilePath(filePath: string, importFrom: string): string {
+function resolveFilePath(filePath: string, importFrom: string): string {
   const dirName = dirname(filePath);
   try {
-    const fullPath = join(dirName, importFrom);
-    return realpathSync(fullPath);
+    const base = join(dirName, importFrom);
+    const candidates = [base, base + '.graphql', base + '.gql'];
+    for (const p of candidates) {
+      try {
+        return realpathSync(p);
+      } catch (e: any) {
+        if (e?.code !== 'ENOENT') throw e;
+      }
+    }
   } catch (e: any) {
     if (e.code === 'ENOENT') {
       return resolveFrom(dirName, importFrom);
     }
     throw e;
   }
 }

---

685-711: Match tsconfig paths semantics by preferring more specific alias patterns.

Iterating Object.entries() order may mis-pick when multiple patterns match. Sort to prefer exact matches over wildcards and longer prefixes first.

-function applyPathAliases(filePath: string, pathAliases?: PathAliases): string {
+function applyPathAliases(filePath: string, pathAliases?: PathAliases): string {
   if (pathAliases == null) {
     return filePath;
   }
 
-  for (const [prefixPattern, mapping] of Object.entries(pathAliases.mappings)) {
+  const entries = Object.entries(pathAliases.mappings).sort((a, b) => {
+    const [ap] = a;
+    const [bp] = b;
+    const aIsWildcard = ap.endsWith('*') ? 1 : 0;
+    const bIsWildcard = bp.endsWith('*') ? 1 : 0;
+    if (aIsWildcard !== bIsWildcard) return aIsWildcard - bIsWildcard; // exact before wildcard
+    const aLen = ap.replace('*', '').length;
+    const bLen = bp.replace('*', '').length;
+    return bLen - aLen; // longer (more specific) first
+  });
+
+  for (const [prefixPattern, mapping] of entries) {
     const matchedMapping = applyPathAlias(prefixPattern, mapping, filePath);
     if (matchedMapping == null) {
       continue;
     }
 
-    const resolvedMapping = resolveFrom(pathAliases.rootDir ?? process.cwd(), matchedMapping);
-    return realpathSync(resolvedMapping);
+    const baseDir = pathAliases.rootDir ?? process.cwd();
+    const resolvedMapping = resolveFrom(baseDir, matchedMapping);
+    return realpathSync(resolvedMapping);
   }
 
   return filePath;
 }

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.