Conversation
🦋 Changeset detectedLatest commit: 29ac2ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment was marked as resolved.
This comment was marked as resolved.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jdolle
force-pushed
the
federation-directives-builtin
branch
from
74187f6 to
8447a90
Compare
|
|
||
| const builtinTypes = ['String', 'Float', 'Int', 'Boolean', 'ID', 'Upload']; | ||
|
|
||
| const federationV1Directives = ['key', 'provides', 'requires', 'external']; |
There was a problem hiding this comment.
removed link from this list per our discussion
jdolle
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| .filter(l => ![linkUrl, federationUrl].includes(l.identity)) | ||
| .flatMap(l => l.imports.map(i => i.as ?? i.name)); | ||
| for (const namedImport of imported) { | ||
| addDefinition(namedImport); |
There was a problem hiding this comment.
I recall that, thankfully, for whatever reason, non-federation packages dont support the namespaced import syntax.
|
One consideration with this change is that I am leaving the builtins for federation v1 directives. |
* Adjust dependency and definition logic to include federated links * chore(dependencies): updated changesets for modified dependencies --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 participants
Description
Some directives for GraphQL Federation are missing from the list of built-ins. This is because the current setup is intended to only handle federation 1.
Federation 2 requires handling aliases etc.
This modifies the logic to handle links per federation 2 definition.
Related #7224
Type of change
Checklist:
CONTRIBUTING doc and the
style guidelines of this project