Copy Symbols as well in copyOwnPropsIfNotPresent#4505
Copy Symbols as well in copyOwnPropsIfNotPresent#4505ardatan merged 2 commits intoardatan:masterfrom
copyOwnPropsIfNotPresent#4505Conversation
🦋 Changeset detectedLatest commit: c0a70fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@Hetch3t is attempting to deploy a commit to the The Guild Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for the PR! Would you add some unit tests to prevent future regressions and changeset(using yarn changeset)? |
ardatan
force-pushed
the
master
branch
2 times, most recently
from
4946aeb to
4be9073
Compare
|
We just encountered this same issue when attempting to mock the Other than needing tests, is there anything else that is blocking this fix from making it into a release? At over a year old, is this PR still valid? I see that it's listed in the project roadmap, but just wanted to give it a bump. |
|
@bkalbs-wm would you be able to contribute a test for this? |
|
@Urigo i can give it a go once I get some breathing room from this work deadline i am on. would like to help however i can. I can open up a new PR once ready. |
ardatan
force-pushed
the
master
branch
5 times, most recently
from
d34fb65 to
b8bf584
Compare
|
Warning Rate limit exceeded@ardatan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 23 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ardatan
force-pushed
the
copy-symbols-as-well-during-mocking
branch
from
6017864 to
c0a70fd
Compare
|
I added a test and a changeset! Thanks for the PR! |
4 participants
Hi!
I had issues with mocking lib - we use
ObjectIdfrom Mongo as an ID scalar type, so after introducing mocking to our schema it started to fail. After hefty amount of time debugging it turned out thatObjectIdis implemented in such a way that is is stored as buffer asSymbol(id). Function that is being used in@graphql-tools/mockusesObject.getOwnPropertyNameswhich doesn't listSymbols. The solution I've implemented you can see in this PR.