feat(resolvers-composition): add support for glob patterns by ntziolis · Pull Request #3132 · ardatan/graphql-tools

ntziolis · 2021-07-04T09:33:06Z

Description

Added support for glob patters for the resolvers-composition package.

Related ardatan/graphql-mesh#2407

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Existing uit tests still pass. Added 2 additional unit test.

Checklist:

I have followed the CONTRIBUTING doc and the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests and linter rules pass locally with my changes
Any dependent changes have been merged and published in downstream modules

changeset-bot · 2021-07-04T09:33:09Z

🦋 Changeset detected

Latest commit: d3e3a11

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ardatan · 2021-07-04T11:54:42Z

Thank you @ntziolis !
Could you fix the TS errors and add a changeset?

ntziolis · 2021-07-04T12:37:03Z

Sure thing. I will also update the docs where needed. Well let you know when it's done.

ntziolis · 2021-07-04T14:30:25Z

Its done, also added 2 unit tests for glob field patters as well as updated the documentation with samples for supported match formats.

* feat(resolvers-composition): add support for glob patterns * fix(resolvers-composition): add typings for micromatch * feat(resolvers-composition): add unit tests for glob patterns * chore(resolver-compositions): cleanup * feat(docs): added samples for resolver composition path matcher format * chore: added changeset * fix(docs): typo * fix(changeset): change patch to minor * Fix tests and cleanup Co-authored-by: Arda TANRIKULU <[email protected]>

API routes generation fix docs & components update; routing fixes gitignore update fix(deps): update dependency extract-files to v11 (ardatan#3065) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update dependency tslib to ~2.3.0 (ardatan#3067) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update dependency the-guild-components to v1.3.1 (ardatan#3070) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update dependency apollo-upload-client to v16 (ardatan#3066) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update typescript-eslint monorepo to v4.27.0 (ardatan#3071) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update babel monorepo to v7.14.6 (ardatan#3072) Co-authored-by: Renovate Bot <[email protected]> [deploy_website] Update generate-schema.md (ardatan#3074) corrected grammar fix(deps): update dependency globby to v11.0.4 (ardatan#3077) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update dependency ws to v7.5.0 (ardatan#3078) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency typescript to v4.3.3 (ardatan#3083) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency typedoc to v0.20.37 (ardatan#3082) Co-authored-by: Renovate Bot <[email protected]> Jest Transformer for GraphQL (ardatan#1887) * Jest Transformer for GraphQL * Changeset * Align versions * Fix package.json * yarn.lock * Fix Co-authored-by: Arda TANRIKULU <[email protected]> chore(deps): update dependency @types/ws to v7.4.5 (ardatan#3084) Co-authored-by: Renovate Bot <[email protected]> Safer use of `Object.prototype.hasOwnProperty` (ardatan#3069) * Safer use of `Object.prototype.hasOwnProperty` Fixes an error I get when GraphQL JS passes a prototypeless object into the resolver ``` ReferenceError: maybeRef is not defined at eval (eval at <anonymous> (/Users/mattalexander/Projects/edge-sites-schema/tests/regression.test.js:67:7), <anonymous>:1:38) at forEach (/projectpath/tests/regression.test.js:67:7) at Array.forEach (<anonymous>) at Object.<anonymous> (/projectpath/tests/regression.test.js:65:17) ``` * changeset and test Co-authored-by: Arda TANRIKULU <[email protected]> BugFix: Handle parsing endpoints when there are no mutations (ardatan#3076) * BugFix: Handle parsing endpoints when there are no mutations * changeset and test * pass tests Co-authored-by: itai <[email protected]> Co-authored-by: Arda TANRIKULU <[email protected]> chore(deps): update dependency typescript to v4.3.4 (ardatan#3086) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency typedoc to v0.21.0 (ardatan#3087) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency typedoc-plugin-markdown to v3.10.0 (ardatan#3088) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency eslint to v7.29.0 (ardatan#3089) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency graphql to v15.5.1 (ardatan#3091) Co-authored-by: Renovate Bot <[email protected]> enable typescript strict mode (ardatan#3010) * enable noImplicitThis * enable `strictBindCallApply` * enable `strictFunctionTypes` 1: testing * enable `strictFunctionTypes` 2: utils * enable strictFunctionTypes 3: schema * enable strictFunctionTypes 4: batch-execute * enable strictFunctionTypes 5 `load` * enable strictFunctionTypes 6 `loaders/url` * enable strictFunctionTypes 7 `webpack-loader` * enable strictFunctionTypes 8 `links` * enable strictFunctionTypes 9 `delegate` and `batch-delegate` * enable `strictFunctionTypes` 10 `wrap` * enable `strictFunctionTypes` 11 `stitch` and `stitching-directive` * enable `strictFunctionTypes` final tsconfig * remove unnecessary generic params * enable `strictNullChecks` 1 `utils` * enable `strictNullChecks` 2 `schema` * enable `strictNullChecks` 3 `resolvers-composition` * enable `strictNullChecks` 4 `webpack-loader` * enable `strictNullChecks` 5 `batch-execute` * enable `strictNullChecks` 6 `graphql-tag-plug` * enable `strictNullChecks` 7 `import` * enable `strictNullChecks` 8 `loaders/url` * enable `strictNullChecks` 8 `loaders/prisma` * enable `strictNullChecks` 8 `loaders/module` * enable `strictNullChecks` 9 `loaders/github` * enable `strictNullChecks` 12 `loaders/code-file` * enable `strictNullChecks` 13 `load` * enable `strictNullChecks` 14 `delegate` * enable `strictNullChecks` 15 `batch-delegate` * interlude: move commonly used stuff to testing folder * enable `strictNullChecks` 16 `wrap` * enable `strictNullChecks` 17 `stitch` * enable `strictNullChecks` 18 `load-files` * enable `strictNullChecks` 19 `load-typedefs` * enable `strictNullChecks` 20 `merge` * enable `strictNullChecks` 21 `node-require` * enable `strictNullChecks` 22 `mock` * enable `strictNullChecks` 22 `stitching-directive` * enable `strictNullChecks` flag in tsconfig * fix: graphql-js 14 compat * fix `strictPropertyInitialization` errors * enable strictPropertyInitialization rule * strict mode!!! * enable `noPropertyAccessFromIndexSignature` * enable `noFallthroughCasesInSwitch` and `noPropertyAccessFromIndexSignature` * Add strict to new changes * fix: remove casts as upstream issue is fixed * fix: throw if we cannot identify the operation type. ardatan#3010 (comment) ardatan#3010 (comment) * fix: change wording of error ardatan#3010 (comment) * fix: make error message more clear ardatan#3010 (comment) * refactor: use null/undefined instead of falsey check * fix: assert operation from document ardatan#3010 (comment) * fix: type narrowing not working due to generics ardatan#3010 (comment) * fix: apply feedback for relocateError * Make wrapSchema generic. Fix ardatan#3064 (#1) * Fix Build Co-authored-by: Arda TANRIKULU <[email protected]> Co-authored-by: Augustin Le Fèvre <[email protected]> Huge cleanup before major release (breaking) (ardatan#3081) * Breaking cleanup before major release * Fix TS * More chore(deps): update typescript-eslint monorepo to v4.28.0 (ardatan#3093) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update babel monorepo to v7.14.7 (ardatan#3094) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update jest monorepo to v27.0.5 (ardatan#3095) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency @vue/compiler-sfc to v3.1.2 (ardatan#3097) Co-authored-by: Renovate Bot <[email protected]> fix build errors Huge cleanup before major release (breaking) (ardatan#3081) * Breaking cleanup before major release * Fix TS * More chore(deps): update typescript-eslint monorepo to v4.28.0 (ardatan#3093) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update babel monorepo to v7.14.7 (ardatan#3094) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update jest monorepo to v27.0.5 (ardatan#3095) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency @vue/compiler-sfc to v3.1.2 (ardatan#3097) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update dependency the-guild-components to v1.4.0 (ardatan#3098) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency @types/node to v14.17.4 (ardatan#3101) Co-authored-by: Renovate Bot <[email protected]> Some other refactor (ardatan#3096) * Fix typing errors in tests * ReplaObject.keys/values and forEach with for..in and for..of loops * Improve Type Checking * Update CI workflow * Fix linting * Fix TS errors for v14 * More * More * Allow incremental builds * Finish * Fix Type Check * Disable sourcemaps * Fix type issues Better changelog Respect and in and more changes chore(CI): Ability to release canaries on demand Make AggregateError spec compliant reintegration docs update updated tgc version and removed Poppins import Able to release with custom tags chore(deps): update dependency typedoc-plugin-markdown to v3.10.2 (ardatan#3107) Co-authored-by: Renovate Bot <[email protected]> Prevent TS Server to die on VSCode chore(deps): update dependency typedoc to v0.21.1 (ardatan#3108) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency graphql-tag to v2.12.5 (ardatan#3109) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency prettier to v2.3.2 (ardatan#3110) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency typedoc to v0.21.2 (ardatan#3111) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency @types/babel__traverse to v7.14.0 (ardatan#3112) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update jest monorepo to v27.0.6 (ardatan#3115) Co-authored-by: Renovate Bot <[email protected]> Remove Subscriber and use only Executor (ardatan#3117) * Remove Subscriber and use only Executor * Fix introspectSchema * Fix tests * Cleanup fix(deps): update dependency ws to v7.5.1 (ardatan#3118) Co-authored-by: Renovate Bot <[email protected]> enhance(url-loader): refactor Fix rawSDL issue enhance(delegate): skip validation by default and add validateRequest option to enable chore(deps): update dependency typescript to v4.3.5 (ardatan#3122) Co-authored-by: Renovate Bot <[email protected]> fix(file-loader): location path must be normalized (ardatan#3121) chore(deps): update dependency husky to v7 (ardatan#3123) Co-authored-by: Renovate Bot <[email protected]> feat(graphql-tag-pluck): keep locationOffset and return graphql-js Source instead of string chore(deps): update dependency @vue/compiler-sfc to v3.1.3 (ardatan#3125) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency @vue/compiler-sfc to v3.1.4 (ardatan#3126) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update dependency @types/websocket to v1.0.3 (ardatan#3129) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency @types/ws to v7.4.6 (ardatan#3128) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency eslint to v7.30.0 (ardatan#3130) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update dependency ws to v7.5.2 (ardatan#3131) Co-authored-by: Renovate Bot <[email protected]> fix(url-loader): fix node support for EventSource feat(resolvers-composition): add support for glob patterns (ardatan#3132) * feat(resolvers-composition): add support for glob patterns * fix(resolvers-composition): add typings for micromatch * feat(resolvers-composition): add unit tests for glob patterns * chore(resolver-compositions): cleanup * feat(docs): added samples for resolver composition path matcher format * chore: added changeset * fix(docs): typo * fix(changeset): change patch to minor * Fix tests and cleanup Co-authored-by: Arda TANRIKULU <[email protected]> chore(deps): pin dependency @types/micromatch to 4.0.1 (ardatan#3133) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency nock to v13.1.1 (ardatan#3134) Co-authored-by: Renovate Bot <[email protected]> don't throw on errors that should not be relocated (ardatan#3136) refactor: internal StitchingInfo properties (ardatan#3137) to never be undefined docs update docs update after review Some fixes update tgc version

API routes generation fix docs & components update; routing fixes gitignore update fix(deps): update dependency extract-files to v11 (#3065) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update dependency tslib to ~2.3.0 (#3067) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update dependency the-guild-components to v1.3.1 (#3070) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update dependency apollo-upload-client to v16 (#3066) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update typescript-eslint monorepo to v4.27.0 (#3071) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update babel monorepo to v7.14.6 (#3072) Co-authored-by: Renovate Bot <[email protected]> [deploy_website] Update generate-schema.md (#3074) corrected grammar fix(deps): update dependency globby to v11.0.4 (#3077) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update dependency ws to v7.5.0 (#3078) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency typescript to v4.3.3 (#3083) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency typedoc to v0.20.37 (#3082) Co-authored-by: Renovate Bot <[email protected]> Jest Transformer for GraphQL (#1887) * Jest Transformer for GraphQL * Changeset * Align versions * Fix package.json * yarn.lock * Fix Co-authored-by: Arda TANRIKULU <[email protected]> chore(deps): update dependency @types/ws to v7.4.5 (#3084) Co-authored-by: Renovate Bot <[email protected]> Safer use of `Object.prototype.hasOwnProperty` (#3069) * Safer use of `Object.prototype.hasOwnProperty` Fixes an error I get when GraphQL JS passes a prototypeless object into the resolver ``` ReferenceError: maybeRef is not defined at eval (eval at <anonymous> (/Users/mattalexander/Projects/edge-sites-schema/tests/regression.test.js:67:7), <anonymous>:1:38) at forEach (/projectpath/tests/regression.test.js:67:7) at Array.forEach (<anonymous>) at Object.<anonymous> (/projectpath/tests/regression.test.js:65:17) ``` * changeset and test Co-authored-by: Arda TANRIKULU <[email protected]> BugFix: Handle parsing endpoints when there are no mutations (#3076) * BugFix: Handle parsing endpoints when there are no mutations * changeset and test * pass tests Co-authored-by: itai <[email protected]> Co-authored-by: Arda TANRIKULU <[email protected]> chore(deps): update dependency typescript to v4.3.4 (#3086) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency typedoc to v0.21.0 (#3087) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency typedoc-plugin-markdown to v3.10.0 (#3088) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency eslint to v7.29.0 (#3089) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency graphql to v15.5.1 (#3091) Co-authored-by: Renovate Bot <[email protected]> enable typescript strict mode (#3010) * enable noImplicitThis * enable `strictBindCallApply` * enable `strictFunctionTypes` 1: testing * enable `strictFunctionTypes` 2: utils * enable strictFunctionTypes 3: schema * enable strictFunctionTypes 4: batch-execute * enable strictFunctionTypes 5 `load` * enable strictFunctionTypes 6 `loaders/url` * enable strictFunctionTypes 7 `webpack-loader` * enable strictFunctionTypes 8 `links` * enable strictFunctionTypes 9 `delegate` and `batch-delegate` * enable `strictFunctionTypes` 10 `wrap` * enable `strictFunctionTypes` 11 `stitch` and `stitching-directive` * enable `strictFunctionTypes` final tsconfig * remove unnecessary generic params * enable `strictNullChecks` 1 `utils` * enable `strictNullChecks` 2 `schema` * enable `strictNullChecks` 3 `resolvers-composition` * enable `strictNullChecks` 4 `webpack-loader` * enable `strictNullChecks` 5 `batch-execute` * enable `strictNullChecks` 6 `graphql-tag-plug` * enable `strictNullChecks` 7 `import` * enable `strictNullChecks` 8 `loaders/url` * enable `strictNullChecks` 8 `loaders/prisma` * enable `strictNullChecks` 8 `loaders/module` * enable `strictNullChecks` 9 `loaders/github` * enable `strictNullChecks` 12 `loaders/code-file` * enable `strictNullChecks` 13 `load` * enable `strictNullChecks` 14 `delegate` * enable `strictNullChecks` 15 `batch-delegate` * interlude: move commonly used stuff to testing folder * enable `strictNullChecks` 16 `wrap` * enable `strictNullChecks` 17 `stitch` * enable `strictNullChecks` 18 `load-files` * enable `strictNullChecks` 19 `load-typedefs` * enable `strictNullChecks` 20 `merge` * enable `strictNullChecks` 21 `node-require` * enable `strictNullChecks` 22 `mock` * enable `strictNullChecks` 22 `stitching-directive` * enable `strictNullChecks` flag in tsconfig * fix: graphql-js 14 compat * fix `strictPropertyInitialization` errors * enable strictPropertyInitialization rule * strict mode!!! * enable `noPropertyAccessFromIndexSignature` * enable `noFallthroughCasesInSwitch` and `noPropertyAccessFromIndexSignature` * Add strict to new changes * fix: remove casts as upstream issue is fixed * fix: throw if we cannot identify the operation type. #3010 (comment) #3010 (comment) * fix: change wording of error #3010 (comment) * fix: make error message more clear #3010 (comment) * refactor: use null/undefined instead of falsey check * fix: assert operation from document #3010 (comment) * fix: type narrowing not working due to generics #3010 (comment) * fix: apply feedback for relocateError * Make wrapSchema generic. Fix #3064 (#1) * Fix Build Co-authored-by: Arda TANRIKULU <[email protected]> Co-authored-by: Augustin Le Fèvre <[email protected]> Huge cleanup before major release (breaking) (#3081) * Breaking cleanup before major release * Fix TS * More chore(deps): update typescript-eslint monorepo to v4.28.0 (#3093) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update babel monorepo to v7.14.7 (#3094) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update jest monorepo to v27.0.5 (#3095) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency @vue/compiler-sfc to v3.1.2 (#3097) Co-authored-by: Renovate Bot <[email protected]> fix build errors Huge cleanup before major release (breaking) (#3081) * Breaking cleanup before major release * Fix TS * More chore(deps): update typescript-eslint monorepo to v4.28.0 (#3093) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update babel monorepo to v7.14.7 (#3094) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update jest monorepo to v27.0.5 (#3095) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency @vue/compiler-sfc to v3.1.2 (#3097) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update dependency the-guild-components to v1.4.0 (#3098) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency @types/node to v14.17.4 (#3101) Co-authored-by: Renovate Bot <[email protected]> Some other refactor (#3096) * Fix typing errors in tests * ReplaObject.keys/values and forEach with for..in and for..of loops * Improve Type Checking * Update CI workflow * Fix linting * Fix TS errors for v14 * More * More * Allow incremental builds * Finish * Fix Type Check * Disable sourcemaps * Fix type issues Better changelog Respect and in and more changes chore(CI): Ability to release canaries on demand Make AggregateError spec compliant reintegration docs update updated tgc version and removed Poppins import Able to release with custom tags chore(deps): update dependency typedoc-plugin-markdown to v3.10.2 (#3107) Co-authored-by: Renovate Bot <[email protected]> Prevent TS Server to die on VSCode chore(deps): update dependency typedoc to v0.21.1 (#3108) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency graphql-tag to v2.12.5 (#3109) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency prettier to v2.3.2 (#3110) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency typedoc to v0.21.2 (#3111) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency @types/babel__traverse to v7.14.0 (#3112) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update jest monorepo to v27.0.6 (#3115) Co-authored-by: Renovate Bot <[email protected]> Remove Subscriber and use only Executor (#3117) * Remove Subscriber and use only Executor * Fix introspectSchema * Fix tests * Cleanup fix(deps): update dependency ws to v7.5.1 (#3118) Co-authored-by: Renovate Bot <[email protected]> enhance(url-loader): refactor Fix rawSDL issue enhance(delegate): skip validation by default and add validateRequest option to enable chore(deps): update dependency typescript to v4.3.5 (#3122) Co-authored-by: Renovate Bot <[email protected]> fix(file-loader): location path must be normalized (#3121) chore(deps): update dependency husky to v7 (#3123) Co-authored-by: Renovate Bot <[email protected]> feat(graphql-tag-pluck): keep locationOffset and return graphql-js Source instead of string chore(deps): update dependency @vue/compiler-sfc to v3.1.3 (#3125) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency @vue/compiler-sfc to v3.1.4 (#3126) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update dependency @types/websocket to v1.0.3 (#3129) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency @types/ws to v7.4.6 (#3128) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency eslint to v7.30.0 (#3130) Co-authored-by: Renovate Bot <[email protected]> fix(deps): update dependency ws to v7.5.2 (#3131) Co-authored-by: Renovate Bot <[email protected]> fix(url-loader): fix node support for EventSource feat(resolvers-composition): add support for glob patterns (#3132) * feat(resolvers-composition): add support for glob patterns * fix(resolvers-composition): add typings for micromatch * feat(resolvers-composition): add unit tests for glob patterns * chore(resolver-compositions): cleanup * feat(docs): added samples for resolver composition path matcher format * chore: added changeset * fix(docs): typo * fix(changeset): change patch to minor * Fix tests and cleanup Co-authored-by: Arda TANRIKULU <[email protected]> chore(deps): pin dependency @types/micromatch to 4.0.1 (#3133) Co-authored-by: Renovate Bot <[email protected]> chore(deps): update dependency nock to v13.1.1 (#3134) Co-authored-by: Renovate Bot <[email protected]> don't throw on errors that should not be relocated (#3136) refactor: internal StitchingInfo properties (#3137) to never be undefined docs update docs update after review Some fixes update tgc version

zorji · 2022-06-06T23:54:59Z

Hi @ardatan @ntziolis

This PR looks like a breaking change.

Before this PR, it's possible to use Mutation: resolvers. After this PR, it has to be changed to 'Mutation.*': resolvers.

Is this expected?

ntziolis · 2022-06-13T08:14:43Z

@zorji Obviously not intended to break backwards compatibility. Apologize for the inconvenience :(

That said I think that Mutation: resolvers worked at all was a coincidence and not officially supported (I could be wrong but from a quick glance of the code and old doc this seems to be the case). Hence we didn't test for this case when checking for backward compatibility.

zorji · 2022-06-13T09:03:48Z

@ntziolis No problems. Thanks for letting me know. I was thinking whether I should wait for a fix or just update the usages. If it's not intended to be supported then it's all good.

feat(resolvers-composition): add support for glob patterns

157e3f6

dotansimha requested a review from ardatan July 4, 2021 11:16

ardatan approved these changes Jul 4, 2021

View reviewed changes

ntziolis added 6 commits July 4, 2021 16:10

fix(resolvers-composition): add typings for micromatch

c642e91

feat(resolvers-composition): add unit tests for glob patterns

2c2b362

chore(resolver-compositions): cleanup

6e5b508

feat(docs): added samples for resolver composition path matcher format

5bfeeac

chore: added changeset

5b1ae7b

fix(docs): typo

ff9ea63

fix(changeset): change patch to minor

f8c57bf

ntziolis requested a review from ardatan July 4, 2021 15:30

Fix tests and cleanup

d3e3a11

ardatan merged commit 4430744 into ardatan:master Jul 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(resolvers-composition): add support for glob patterns#3132

feat(resolvers-composition): add support for glob patterns#3132
ardatan merged 9 commits intoardatan:masterfrom
ntziolis:glop-patterns-for-resolver-composition

ntziolis commented Jul 4, 2021 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jul 4, 2021 •

edited

Loading

Uh oh!

ardatan commented Jul 4, 2021

Uh oh!

ntziolis commented Jul 4, 2021

Uh oh!

ntziolis commented Jul 4, 2021

Uh oh!

zorji commented Jun 6, 2022

Uh oh!

ntziolis commented Jun 13, 2022 •

edited

Loading

Uh oh!

zorji commented Jun 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ntziolis commented Jul 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

changeset-bot Bot commented Jul 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

ardatan commented Jul 4, 2021

Uh oh!

ntziolis commented Jul 4, 2021

Uh oh!

ntziolis commented Jul 4, 2021

Uh oh!

zorji commented Jun 6, 2022

Uh oh!

ntziolis commented Jun 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zorji commented Jun 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ntziolis commented Jul 4, 2021 •

edited

Loading

changeset-bot Bot commented Jul 4, 2021 •

edited

Loading

ntziolis commented Jun 13, 2022 •

edited

Loading