ANW-1763: Add "Create and Link" for Related Accessions by Zeff · Pull Request #3830 · archivesspace/archivesspace

Zeff · 2025-12-19T02:59:47Z

Summary

Adds inline creation functionality for Related Accessions on Resource forms. Users can now create a new accession directly from the Resource edit form via a modal, without navigating away from the page.

ANW-1763

Implementation Details

Follows existing inline creation pattern used by Subjects, Agents, and Top Containers
Controller checks inline? parameter to return JSON (inline) vs redirect (normal)
Permission-gated: "Create" button only visible to users with update_accession_record permission
Full form rendered in modal (not minimal form) for complete data entry in one step
JavaScript handled by existing linker.js (no JS changes needed)

Screenshots

How to Test

Create a new resource (or navigate to a Resource edit page)
Fill out required Resource fields if needed
Find "Related Accessions" section
Click the Accession dropdown
Click the new "Create" option in the dropdown
Create Accession form should be displayed in a modal window
Fill out required fields and save
Modal form should close and linked accession displayed in resource

Zeff · 2025-12-19T03:04:13Z

@thimios this still needs work but the basic functions are there. I need to get rid of the extra Create and Cancel buttons. I tried to reuse the full form and didn't think about that. Looks like that weird formatting you found in my last PR is in many files. So still cleaning up and need to add specs. Took some time trying to wrap my head around some of our helper functions.

coveralls · 2025-12-19T03:33:01Z

Pull Request Test Coverage Report for Build 21668976405

Details

5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
9509 unchanged lines in 269 files lost coverage.
Overall coverage decreased (-27.4%) to 51.925%

Files with Coverage Reduction	New Missed Lines	%
backend/app/controllers/component_transfer.rb	1	75.0%
backend/app/controllers/version.rb	1	80.0%
backend/app/model/mixins/directional_relationships.rb	1	97.44%
backend/app/model/vocabulary.rb	1	85.71%
backend/app/model/structured_date_range.rb	1	77.78%
backend/app/model/ASModel.rb	1	97.14%
backend/app/controllers/assessment.rb	1	91.67%
backend/app/model/collection_management.rb	1	86.67%
backend/app/controllers/system.rb	1	33.33%
frontend/app/models/edit_mediator.rb	1	91.53%

Totals
Change from base Build 15878865621:	-27.4%
Covered Lines:	16336
Relevant Lines:	31461

💛 - Coveralls

thimios · 2025-12-19T17:05:47Z

@Zeff looks good!

brianzelip

@Zeff looks great! The patterns here match the other three record types for including the linker Create option.

I notice that Accessions also have frontend/app/views/accession_links/_accession_linker.html.erb, which is the linker used by Archival Objects. (I'm not sure why this is the case.)

So this PR adds the Create option for the Related Accessions linker for the Resources and Accessions forms, but not the Archival Object form, see below:

Can you look into extending the linker Create option to this second accession linker?

Zeff · 2026-01-07T16:11:49Z

@brianzelip

I notice that Accessions also have frontend/app/views/accession_links/_accession_linker.html.erb, which is the linker used by Archival Objects. (I'm not sure why this is the case.)

So this PR adds the Create option for the Related Accessions linker for the Resources and Accessions forms, but not the Archival Object form, see below:
Can you look into extending the linker Create option to this second accession linker?

Great catch! Digging in.

brianzelip

@Zeff I noticed on the "Create modal" that pops up via the "Accession Links" subform on an Archival Object form which you just added, there's no modal header. The modal header should contain the heading "Create Accession" and a close button, but it's not there. It's possible this is unrelated to your work.

Can you please look into correcting this?

Screenshots

No header on an Archival Object "Accession Links" subform Create modal

With header on the Archival Object "Subjects" subform Create modal

(This subform is just beneath the "Accession Links" subform)

With header on the Resource "Related Accessions" Create modal

Zeff · 2026-01-20T15:40:13Z

@Zeff I noticed on the "Create modal" that pops up via the "Accession Links" subform on an Archival Object form which you just added, there's no modal header. The modal header should contain the heading "Create Accession" and a close button, but it's not there. It's possible this is unrelated to your work.

Can you please look into correcting this?

Fixed with latest commit.

thimios · 2026-01-16T14:33:43Z

+  wait_for_ajax
+end
+
+When('the user clicks {string} in the dropdown menu') do |menu_item|


Could this step be replaced by this already existing one? https://github.com/archivesspace/archivesspace/blob/master/e2e-tests/staff_features/shared/step_definitions.rb#L135

thimios · 2026-01-16T14:36:59Z

+  wait_for_ajax
+end
+
+Then('the related accession creation modal should be displayed') do


Rephrase as "the Related Accession creation modal is displayed" to follow the language of the rest of the test suite

thimios · 2026-01-16T14:56:17Z

+  end
+end
+
+When('the user fills in the inline accession form') do |table|


Can we reuse the "the user fills in... " steps from file: https://github.com/archivesspace/archivesspace/blob/master/e2e-tests/staff_features/shared/step_definitions.rb for example https://github.com/archivesspace/archivesspace/blob/master/e2e-tests/staff_features/shared/step_definitions.rb#L147 and the ones after that instead of creating this new step here?

See also how the other creation scenarios are written, such as: https://github.com/archivesspace/archivesspace/blob/master/e2e-tests/staff_features/resources/resource_create.feature

Fixed. Ultimately, I was able to get rid of two of my step definitions with reusing the shared ones. Took a little tweaking. Also, I missed the selector pattern that was being used and fixed that in a few places as well where I went with the modal ID.

Thanks, @thimios! This is definitely better. I'd love to spend some time in this to really get our e2e tests in my head and do even more cleanup.

You'll notice the entire feature was updated ... it was a line ending issue. In addition to the few step changes, changed all the line endings from CR/LF to LF. Not sure how that happened. Might have been my editor.

brianzelip · 2026-01-21T16:13:22Z

@Zeff @thimios This PR should wait for #3876 to be merged into master for any potential linker merge conflicts.

thimios · 2026-01-28T16:17:50Z

+    And the user fills in 'accession_title_' with 'Test Related Accession' in the modal
+    And the user fills in 'accession_accession_date_' with '2026-01-05' in the modal
+    And the user clicks on 'Create and Link' in the modal
+    Then the modal should close


Let's remove this assertion as discussed

thimios · 2026-01-28T16:20:30Z

+    And the user fills in 'accession_accession_date_' with '2026-01-05' in the modal
+    And the user clicks on 'Create and Link' in the modal
+    Then the modal should close
+    And the accession 'Test Related Accession' should appear in the related accessions linker


Let's remove also this then step from here

thimios · 2026-01-28T16:23:11Z

+    Then the modal should close
+    And the accession 'Test Related Accession' should appear in the related accessions linker
+
+    When the user saves the resource


Use the 'click the "save resource" step'

brianzelip · 2026-01-29T19:52:45Z

@Zeff the linker-related PR has now been merged, so this is ready to go once the feedback from @thimios has been implemented.

Zeff · 2026-02-02T23:50:29Z

@thimios I believe I was able to address the few things you mentioned, but overall I actually:

got rid of almost half of my step definitions in favor of shared step definitions
updated language appropriately
also created a new shared step definition as opposed to having it in my custom step definitions for resources that checks for error messages in modals

So thanks for your guidance here. I feel a lot better about it in its current state.

Ultimately, I found several other things I would like to change, but chose to stop as we should just refactor later. For example, in the helper.rb file, there's a step definition called "Given a Resource has been created", which would make you think you will end on a resource page, but it actually ends on an archival object page because it does more than just create a resource. So my step, 'When the user navigates to edit the resource" is a hack to get around that, but I didn't want to keep fixing these things and hold up the release.

==================== UPDATE =========================
After all that I found two more step definitions I forgot to delete, so I've actually removed more than half of my original step definitions. Thank you for dealing with the churn.

- Add inline Create and Link functionality for Related Accessions - Create accessions controller inline mode (new, create actions) - Add accessions form partials (_new, _form_inline) - Add Create button to accessions linker dropdown - Add E2E tests and RSpec feature tests - Fix child record Accession Links - Add .tool-versions file for e2e-tests

* Fix missing title for Archival Object accession linker * Simplify and reuse shared steps * Correct shared step and tense usage * Remove two more non-shared step definitions

* prefer reusing existing steps than creating new ones * follow existing wording pattern for new steps

Zeff force-pushed the ANW-1763-accession-link-create-option branch from cadd8e3 to f2f913f Compare December 19, 2025 21:24

Zeff force-pushed the ANW-1763-accession-link-create-option branch 2 times, most recently from aa81074 to 48eb162 Compare January 6, 2026 23:21

Zeff commented Jan 6, 2026

View reviewed changes

Comment thread e2e-tests/staff_features/resources/step_definitions/resource_related_accession.rb Outdated

Zeff commented Jan 6, 2026

View reviewed changes

Comment thread frontend/spec/controllers/accessions_controller_spec.rb

Zeff commented Jan 6, 2026

View reviewed changes

Comment thread frontend/spec/controllers/accessions_controller_spec.rb

Zeff commented Jan 6, 2026

View reviewed changes

Comment thread frontend/spec/controllers/accessions_controller_spec.rb

Zeff marked this pull request as ready for review January 7, 2026 13:30

Zeff requested review from brianzelip and thimios January 7, 2026 13:34

brianzelip requested changes Jan 7, 2026

View reviewed changes

Zeff marked this pull request as draft January 7, 2026 16:08

Zeff self-assigned this Jan 7, 2026

Zeff added the feature_request label Jan 7, 2026

Zeff force-pushed the ANW-1763-accession-link-create-option branch from 48eb162 to c0cdeb2 Compare January 7, 2026 20:12

Zeff marked this pull request as ready for review January 8, 2026 19:49

thimios requested a review from brianzelip January 14, 2026 15:08

brianzelip requested changes Jan 16, 2026

View reviewed changes

Zeff requested a review from brianzelip January 20, 2026 15:40

thimios requested changes Jan 20, 2026

View reviewed changes

Zeff force-pushed the ANW-1763-accession-link-create-option branch 2 times, most recently from cc2250e to 7537d52 Compare January 28, 2026 15:34

thimios requested changes Jan 28, 2026

View reviewed changes

Zeff force-pushed the ANW-1763-accession-link-create-option branch from 7537d52 to 725d765 Compare February 2, 2026 23:40

Zeff requested a review from thimios February 3, 2026 15:05

thimios force-pushed the ANW-1763-accession-link-create-option branch from 7a0bc06 to f177cd1 Compare February 4, 2026 08:44

Zeff and others added 3 commits February 4, 2026 13:03

ANW-1763 refactor e2e specs

a0496b4

* Fix missing title for Archival Object accession linker * Simplify and reuse shared steps * Correct shared step and tense usage * Remove two more non-shared step definitions

ANW-1763 refactor e2e specs

f2d5305

* prefer reusing existing steps than creating new ones * follow existing wording pattern for new steps

thimios force-pushed the ANW-1763-accession-link-create-option branch from f177cd1 to f2d5305 Compare February 4, 2026 11:04

thimios approved these changes Feb 4, 2026

View reviewed changes

brianzelip approved these changes Feb 4, 2026

View reviewed changes

brianzelip merged commit cc68eb2 into master Feb 4, 2026
35 of 40 checks passed

brianzelip deleted the ANW-1763-accession-link-create-option branch February 4, 2026 15:55

cdibella added this to the 4.2.0 milestone Mar 9, 2026

Conversation

Zeff commented Dec 19, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Implementation Details

Screenshots

How to Test

Uh oh!

Zeff commented Dec 19, 2025

Uh oh!

coveralls commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 21668976405

Details

💛 - Coveralls

Uh oh!

thimios commented Dec 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brianzelip left a comment

Choose a reason for hiding this comment

Uh oh!

Zeff commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brianzelip left a comment

Choose a reason for hiding this comment

Screenshots

No header on an Archival Object "Accession Links" subform Create modal

With header on the Archival Object "Subjects" subform Create modal

With header on the Resource "Related Accessions" Create modal

Uh oh!

Zeff commented Jan 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brianzelip commented Jan 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brianzelip commented Jan 29, 2026

Uh oh!

Zeff commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Zeff commented Dec 19, 2025 •

edited by atlassian bot

Loading

coveralls commented Dec 19, 2025 •

edited

Loading

Zeff commented Jan 7, 2026 •

edited

Loading

Zeff commented Feb 2, 2026 •

edited

Loading