ANW-2546_add_apple_touch_icon#3789
Merged
brianzelip merged 1 commit intoarchivesspace:masterfrom Nov 18, 2025
Merged
Conversation
Pull Request Test Coverage Report for Build 19446147382Details
💛 - Coveralls |
brianzelip
approved these changes
Nov 18, 2025
Collaborator
brianzelip
left a comment
There was a problem hiding this comment.
Thanks @lorawoodford!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a valid
apple-touch-iconto resolve recurring FATAL log lines as described in JIRA.Description
Related JIRA Ticket or GitHub Issue
https://archivesspace.atlassian.net/browse/ANW-2546
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Maybe? This just uses this existing ASpace favicon, and instructions on how to customize that (and cease using the defaults shipped with ArchivesSpace) are at: https://docs.archivesspace.org/customization/plugins/#customizing-the-favicon As currently delivered, this won't really change any of that.