Skip to content

ANW-2546_add_apple_touch_icon#3789

Merged
brianzelip merged 1 commit intoarchivesspace:masterfrom
lorawoodford:ANW-2546_add_apple_touch_icon
Nov 18, 2025
Merged

ANW-2546_add_apple_touch_icon#3789
brianzelip merged 1 commit intoarchivesspace:masterfrom
lorawoodford:ANW-2546_add_apple_touch_icon

Conversation

@lorawoodford
Copy link
Copy Markdown
Contributor

Adds a valid apple-touch-icon to resolve recurring FATAL log lines as described in JIRA.

Description

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/browse/ANW-2546

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 19446147382

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+1.4%) to 80.682%

Files with Coverage Reduction New Missed Lines %
frontend/app/helpers/digital_object_helper.rb 1 87.5%
backend/app/model/accession.rb 1 98.44%
frontend/app/models/edit_mediator.rb 1 91.53%
frontend/app/controllers/application_controller.rb 1 98.3%
backend/app/controllers/job.rb 1 70.59%
indexer/app/lib/indexer_common.rb 5 99.14%
frontend/app/controllers/archival_objects_controller.rb 5 87.36%
frontend/app/controllers/agents_controller.rb 6 71.09%
Totals Coverage Status
Change from base Build 15878865621: 1.4%
Covered Lines: 28889
Relevant Lines: 35806

💛 - Coveralls

@lorawoodford lorawoodford marked this pull request as ready for review November 17, 2025 23:56
Copy link
Copy Markdown
Collaborator

@brianzelip brianzelip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lorawoodford!

@brianzelip brianzelip merged commit 6da1b35 into archivesspace:master Nov 18, 2025
18 checks passed
@cdibella cdibella added this to the 4.2.0 milestone Mar 9, 2026
@cdibella cdibella added the community code contributed by community members not on or contracted by the ArchivesSpace program team label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community code contributed by community members not on or contracted by the ArchivesSpace program team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants