Skip to content

ANW-2143: Replaces authoritive and authoritative with authorized on people facing labels#3724

Merged
brianzelip merged 3 commits intomasterfrom
ANW-2143-authoritive-should-be-spelled-authoritative-or-authorized-on-people-facing-labels
Oct 9, 2025
Merged

ANW-2143: Replaces authoritive and authoritative with authorized on people facing labels#3724
brianzelip merged 3 commits intomasterfrom
ANW-2143-authoritive-should-be-spelled-authoritative-or-authorized-on-people-facing-labels

Conversation

@cpapazoglou
Copy link
Copy Markdown
Collaborator

@cpapazoglou cpapazoglou commented Sep 30, 2025 •
edited
Loading

Description

  • Replaces authoritive and authoritative with authorized on people facing labels
  • Updated the relevant tooltip to read "Use to indicate the name form is the authorized version of the name by authoritative sources such as LCNAF."
  • Updates relative translations

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/browse/ANW-2143

How Has This Been Tested?

  • Manually
  • Updated automated tests

Screenshots (if appropriate):

Before After
CleanShot 2025-09-30 at 14 20 51@2x CleanShot 2025-09-30 at 14 20 37@2x

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 30, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 18127185892

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.7%) to 79.963%
Files with Coverage Reduction New Missed Lines %
backend/app/controllers/job.rb 1 70.59%
indexer/app/lib/indexer_common.rb 4 99.31%
frontend/app/controllers/archival_objects_controller.rb 5 87.36%
Totals Coverage Status
Change from base Build 15878865621: 0.7%
Covered Lines: 28391
Relevant Lines: 35505
💛 - Coveralls

@cpapazoglou cpapazoglou changed the title ANW-2143-authoritive-should-be-spelled-authoritative-or-authorized-on-people-facing-labels ANW-2143: Replaces authoritive and authoritative with authorized on people facing labels Sep 30, 2025
@cpapazoglou cpapazoglou marked this pull request as ready for review September 30, 2025 10:54
@cpapazoglou cpapazoglou self-assigned this Sep 30, 2025
@cpapazoglou
Copy link
Copy Markdown
Collaborator Author

cpapazoglou commented Sep 30, 2025

The failing tests seem irrelevant to me.

brianzelip
brianzelip approved these changes Oct 9, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@brianzelip brianzelip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cpapazoglou!

@brianzelip brianzelip merged commit 6697bf6 into master Oct 9, 2025
54 of 57 checks passed
@brianzelip brianzelip deleted the ANW-2143-authoritive-should-be-spelled-authoritative-or-authorized-on-people-facing-labels branch October 9, 2025 10:38
@cdibella cdibella added this to the 4.2.0 milestone Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianzelip brianzelip brianzelip approved these changes

Assignees

@cpapazoglou cpapazoglou

Labels

None yet

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cpapazoglou @coveralls @brianzelip @cdibella