Skip to content

ANW-2406 use docker metadata action to generate docker tags#3615

Merged
thimios merged 2 commits intomasterfrom
ANW-2406-use-metadata-action-for-docker-tags
Jun 25, 2025
Merged

ANW-2406 use docker metadata action to generate docker tags#3615
thimios merged 2 commits intomasterfrom
ANW-2406-use-metadata-action-for-docker-tags

Conversation

@thimios
Copy link
Copy Markdown
Collaborator

@thimios thimios commented Jun 5, 2025

Description

Related JIRA Ticket or GitHub Issue

ANW-2406

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@thimios thimios force-pushed the ANW-2406-use-metadata-action-for-docker-tags branch 2 times, most recently from caf883b to 29fb7f7 Compare June 5, 2025 12:27
@thimios thimios marked this pull request as draft June 5, 2025 12:35
@thimios thimios force-pushed the ANW-2406-use-metadata-action-for-docker-tags branch 7 times, most recently from 198e5f8 to 9200570 Compare June 5, 2025 15:15
@thimios thimios force-pushed the ANW-2406-use-metadata-action-for-docker-tags branch from 9200570 to 9092bef Compare June 5, 2025 15:22
@thimios thimios requested a review from mark-cooper June 5, 2025 15:35
@thimios thimios marked this pull request as ready for review June 5, 2025 15:35
@mark-cooper
Copy link
Copy Markdown
Member

@thimios looks nice! Obv. it would be good if this could be generalized:

type=raw,value=mlc-multiple-titles,enable=${{ github.ref_name == 'mlc-multiple-titles' }}

You could rename that branch into some other kind of pattern (like add a prefix) you want to use for building images perhaps? That way it would work for other branches in the future and you won't have to remove this one when it's no longer useful.

@thimios
Copy link
Copy Markdown
Collaborator Author

thimios commented Jun 16, 2025

@thimios looks nice! Obv. it would be good if this could be generalized:

type=raw,value=mlc-multiple-titles,enable=${{ github.ref_name == 'mlc-multiple-titles' }}

You could rename that branch into some other kind of pattern (like add a prefix) you want to use for building images perhaps? That way it would work for other branches in the future and you won't have to remove this one when it's no longer useful.

good point @mark-cooper, could you take another look and possibly approve it so that I can merge it?

@mark-cooper
Copy link
Copy Markdown
Member

@thimios Nice, this version is a lot more readable than the inline bash scripting. I re-read the docker metadata action docs to just to remind myself how it works and everything looks clear to me! You're extracting ANW- prefixes and v prefixes for semver release type stuff, and of course latest on the default branch 👍

So LGTM.

@thimios thimios merged commit b5fd9ef into master Jun 25, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants