ANW-2353: Fix mixed content handling across public and frontend#3509
Merged
ANW-2353: Fix mixed content handling across public and frontend#3509
Conversation
brianzelip
changed the title
brianzelip
force-pushed
the
ANW-2353-pui-mixed-content-not-handled-properly
branch
from
e6757ba to
e74d28f
Compare
thimios
approved these changes
Apr 14, 2025
This was referenced Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes mixed content being mishandled in multiple places throughout the PUI.
Moving the
mixed_content_parserrequire from public/app/views/digital_objects/_linked_instances.html.erb to public/app/views/shared/_mixed_content_link.html.erb fixed a bug that was exposed in local development but not in production where the app crashed due toMixedContentParsernot being available.The tests for mixed content display will come after this PR (via ANW-2360)
ANW-2353
Problem
See ANW-2353 for more examples
Frontend example
Public example
Solutions