Skip to content

ANW-2270 Fix the accession linker prelinker bug on Archival Object forms#3471

Merged
brianzelip merged 3 commits intoarchivesspace:masterfrom
dartmouth-dltg:ANW-2270-fix-acc-links
Feb 25, 2025
Merged

ANW-2270 Fix the accession linker prelinker bug on Archival Object forms#3471
brianzelip merged 3 commits intoarchivesspace:masterfrom
dartmouth-dltg:ANW-2270-fix-acc-links

Conversation

@jdshaw
Copy link
Copy Markdown
Contributor

@jdshaw jdshaw commented Feb 19, 2025 •
edited
Loading

As described in ANW-2270, accession links will be removed on resave if they number more than 5 (and are thus initially hidden)

Description

Updates the linker template for accession links to provide prelinker classed input fields and updates the id for each linker form. Adds additional feature spec for archival object accession links.

Related JIRA Ticket or GitHub Issue

ANW-2270

How Has This Been Tested?

Local Testing under 4.0.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@thimios
Copy link
Copy Markdown
Collaborator

thimios commented Feb 20, 2025

@jdshaw great find! Could you add a feature spec to this?
@brianzelip before merging this we should also ensure that the same issue is fixed (if present) to the rest of the linker views as well.

@cdibella cdibella added this to the 4.0.1 milestone Feb 20, 2025
@jdshaw
Copy link
Copy Markdown
Contributor Author

jdshaw commented Feb 20, 2025

@thimios Will do on the feature spec. Might take a minute to get up to speed on the current state of those, but hopefully next week.

@jdshaw jdshaw changed the title potential fix for ANW-2270 DRAFT: potential fix for ANW-2270 Feb 20, 2025
@jdshaw jdshaw marked this pull request as draft February 20, 2025 14:17
@jdshaw
Copy link
Copy Markdown
Contributor Author

jdshaw commented Feb 20, 2025

I think https://github.com/archivesspace/archivesspace/blob/master/frontend/app/views/component_links/_component_linker.html.erb may need a similar fix, though I could not replicate a similar behavior when adding archival objects to an accession. That makes me wonder if there's something 'special' about the archival object CRUD.

@jdshaw jdshaw changed the title DRAFT: potential fix for ANW-2270 potential fix for ANW-2270 Feb 25, 2025
@jdshaw
Copy link
Copy Markdown
Contributor Author

jdshaw commented Feb 25, 2025

Feature spec added.

@jdshaw jdshaw marked this pull request as ready for review February 25, 2025 13:13
brianzelip
brianzelip reviewed Feb 25, 2025
View reviewed changes
Comment thread frontend/spec/features/archival_objects_spec.rb
@brianzelip brianzelip mentioned this pull request Feb 25, 2025
Merged
@brianzelip
Copy link
Copy Markdown
Collaborator

brianzelip commented Feb 25, 2025 •
edited
Loading

@jdshaw @thimios I looked at all the frontend linkers, including the "component linker" mentioned above, and did not find any other issues, apart from the (minor) duplicate alerts bug on the Classifications subform which has been fixed via #3474.

Once the spec herein is finalized this looks good to merge from my end.

thimios
thimios previously requested changes Feb 25, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@thimios thimios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on the spec, the rest looks good!

Comment thread frontend/spec/features/archival_objects_spec.rb Outdated
Comment thread frontend/spec/features/archival_objects_spec.rb Outdated
Comment thread frontend/spec/features/archival_objects_spec.rb
@jdshaw
Copy link
Copy Markdown
Contributor Author

jdshaw commented Feb 25, 2025

Changes as suggested by @thimios in place.

brianzelip
brianzelip approved these changes Feb 25, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@brianzelip brianzelip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 thanks @jdshaw!

@brianzelip brianzelip dismissed thimios’s stale review February 25, 2025 17:35

The review has been incorporated.

@brianzelip brianzelip merged commit b54e563 into archivesspace:master Feb 25, 2025
@brianzelip brianzelip changed the title potential fix for ANW-2270 ANW-2270 Fix the accession linker prelinker bug on Archival Object forms Feb 25, 2025
@cdibella cdibella added the community code contributed by community members not on or contracted by the ArchivesSpace program team label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianzelip brianzelip brianzelip approved these changes

@thimios thimios thimios left review comments

Assignees

No one assigned

Labels

community code contributed by community members not on or contracted by the ArchivesSpace program team

Projects

None yet

Milestone

4.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@jdshaw @thimios @brianzelip @cdibella