Skip to content

ANW-1505: Adding partial/whole extend in PUI#3383

Merged
brianzelip merged 2 commits intomasterfrom
ANW-1505-partial-vs-whole-extent-should-be-distinguished-in-pui
Nov 18, 2024
Merged

ANW-1505: Adding partial/whole extend in PUI#3383
brianzelip merged 2 commits intomasterfrom
ANW-1505-partial-vs-whole-extent-should-be-distinguished-in-pui

Conversation

@Vchouliaras
Copy link
Copy Markdown
Collaborator

Description

Adds "partial/whole extend" literal on PUI collection overview page

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/browse/ANW-1505

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Vchouliaras Vchouliaras marked this pull request as ready for review November 9, 2024 11:24
Copy link
Copy Markdown
Collaborator

@thimios thimios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a spec for this? I guess the proper place would be: public/spec/features/record_innards_spec.rb

@Vchouliaras
Copy link
Copy Markdown
Collaborator Author

Can we add a spec for this? I guess the proper place would be: public/spec/features/record_innards_spec.rb

I added them

@Vchouliaras Vchouliaras requested a review from thimios November 14, 2024 15:47
@thimios thimios requested a review from brianzelip November 17, 2024 16:54
Copy link
Copy Markdown
Collaborator

@thimios thimios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vchouliaras please ensure that all changes are squashed into a single commit before merging.

Also please do not merge until @brianzelip has also reviewed this PR

@brianzelip brianzelip merged commit 8f2f346 into master Nov 18, 2024
@brianzelip brianzelip deleted the ANW-1505-partial-vs-whole-extent-should-be-distinguished-in-pui branch November 18, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants