@jdshaw thanks for the PR, I am in the process of reviewing it. Could you point me to the plugins that are being fixed by these changes?

@thimios The title isn't the best. I'll changed it to reflect that this PR fixes core code support for plugins.

An example of a plugin that would have broken without these changes: https://github.com/dartmouth-dltg/local_contexts_projects.

@jdshaw that's awesome! It would be very helpful to know which specific plugins you are working with that motivated these changes. I would like to test them out as part of reviewing these changes.

@thimios I've been updating the plugins that I support (list below) and that's how I've been identifying the core changes that needed to be made. For each plugin, if there were changes needed for 4.0, there is a branch labeled as-4.0 (see the local contexts plugin for example) with the plugin specific changes.

The local contexts plugin is a good example since it does all the things: adds shared templates and includes some PUI view additions - like those for the PDF, upper records, and welcome.

Let me know if you see anything wonky or have a better way to approach any of the changes.

1. Local Contexts: https://github.com/dartmouth-dltg/local_contexts_projects
2. Harmful Content: https://github.com/dartmouth-dltg/aspace_content_warnings
3. Reparative Descriptions: https://github.com/dartmouth-dltg/aspace_reparative_descriptions
4. PUI Analytics: https://github.com/dartmouth-dltg/aspace_analytics
5. OmniAuth CAS: https://github.com/dartmouth-dltg/aspace-omniauth-cas
6. Custom Localizations: https://github.com/dartmouth-dltg/aspace_custom_localizations
7. Container Labels: https://github.com/dartmouth-dltg/container_management_labels
8. PUI Sitemap: https://github.com/dartmouth-dltg/aspace_sitemap
9. Custom Restrictions: https://github.com/dartmouth-dltg/aspace_custom_restrictions_and_context
10. Search Modifications: https://github.com/dartmouth-dltg/aspace_search_modifications

I should note that the local contexts plugin is the most complex and requires a bit of config and knowledge of local contexts to get setup. The harmful content plugin is self contained and also relies on most of the core code changes.

@jdshaw looks good to me, could you rebase on master (ci has been updated so you should get a green run then). Could you also squash all the changes into a single commit before merging?

Rebased. Will squash and merge when the tests complete.

@thimios Looks like there are some issues with the Accessibility tests. I'm assuming that's upstream of any changes I made since there's nothing in here that should be affecting accessibiity.

@thimios Looks like there are some issues with the Accessibility tests. I'm assuming that's upstream of any changes I made since there's nothing in here that should be affecting accessibiity.

@jdshaw there is flakiness on those, we are working on fixing it. Go ahead with squashing and I will have to rerun the accessibility specs a couple of times to get them green. Thanks!