ANW-2107 Allow owner repo to be imported via CSV#3275
Merged
thimios merged 2 commits intoarchivesspace:masterfrom Oct 29, 2024
Merged
ANW-2107 Allow owner repo to be imported via CSV#3275thimios merged 2 commits intoarchivesspace:masterfrom
thimios merged 2 commits intoarchivesspace:masterfrom
Conversation
cdibella
added
the
community
thimios
requested changes
Oct 28, 2024
Collaborator
thimios
left a comment
thimios
left a comment
There was a problem hiding this comment.
Looks good to me, some minor change requests added. @lorawoodford could you rebase this on current master and let the test suite run?
| my_converter.instance_variable_set(:@import_options, {}) | ||
| end | ||
|
|
||
| it 'creates location records with owner repo' do |
| filenames = @json.job['filenames'] || [] | ||
| import_maint_events = @json.job["import_events"] == "1" ? true : false | ||
| import_subjects = @json.job["import_subjects"] == "1" ? true : false | ||
| import_repository = @json.job["import_repository"] == "1" ? true : false |
Collaborator
There was a problem hiding this comment.
would be nice to align these lines on "="
| import_repository = opts[:import_repository] | ||
|
|
||
| unless import_events == nil && import_subjects == nil | ||
| unless [import_events, import_subjects, import_repository].all?(&:nil?) |
lorawoodford
force-pushed
the
add_owner_repo_on_loc_import
branch
from
f5e0144 to
af408f6
Compare
thimios
approved these changes
Oct 29, 2024
thimios
pushed a commit
that referenced
this pull request
Nov 1, 2024
ANW-2107 allow owner repo to be imported via CSV when importing locations
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a checkbox to the location CSV importer that allows for the imported location(s) to be linked to the current repo.
Description
Allows for locations to be imported with an associated repo from the start, rather than requiring additional steps after import.
Related JIRA Ticket or GitHub Issue
https://archivesspace.atlassian.net/browse/ANW-2107
How Has This Been Tested?
Some tests added to the backend test suite, as well as manually testing. Happy to add additional tests based off the guidance/review of the dev team.
Screenshots (if appropriate):
Adds the following checkbox:
Types of changes
Checklist: