Merged
Conversation
Passes in the public app proxy url to InfiniteTree/InfiniteRecords so they can properly fetch nodes/waypoints when a proxy is in use. This also ends up involving some changes so that the public URL can be defined at the top level in build.xml and passed to rspec so that AppConfig can be set appropriately and various tests involving the collection organization pages will run successfully. Unfortunately, the accessibilty CI tests run the rspec target directly instead of going through their own setup target like other tests, so the url had to be hardcoded in a parameter definition in the yaml file.
d25cadc to
bdafe41
Compare
thimios
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes several issues discovered with exports and a problem where the new Collection Organization view would be unable to fetch data from the backend and appear to hang indefinitely when used with proxy URLs.