Fix frontend plugin initializer#3052
Merged
brianzelip merged 1 commit intoarchivesspace:masterfrom Sep 24, 2023
Merged
Conversation
Don't assume config.yml has a parent key as it's not required (and for example lcnaf does not).
brianzelip
approved these changes
Sep 24, 2023
Collaborator
brianzelip
left a comment
There was a problem hiding this comment.
Testing locally via the provided commands was a little off but this code works in PR #3014 so approving it now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't assume plugin config.yml has a parent key as it's not required (and for example lcnaf does not).
To replicate
Do something like:
git clone --recurse-submodules https://github.com/archivesspace/archivesspace aspace-with-submodules cd aspace-with-submodules ./build/run build-distHow Has This Been Tested?
As above and locally updated the
hello_worldexample plugin to test the conditions (noparentsand withparents.agent).Types of changes
Checklist: