Skip to content

Fix frontend plugin initializer#3052

Merged
brianzelip merged 1 commit intoarchivesspace:masterfrom
mark-cooper:fix-frontend-plugin-init
Sep 24, 2023
Merged

Fix frontend plugin initializer#3052
brianzelip merged 1 commit intoarchivesspace:masterfrom
mark-cooper:fix-frontend-plugin-init

Conversation

@mark-cooper
Copy link
Copy Markdown
Member

Don't assume plugin config.yml has a parent key as it's not required (and for example lcnaf does not).

To replicate

Do something like:

git clone --recurse-submodules https://github.com/archivesspace/archivesspace aspace-with-submodules
cd aspace-with-submodules
./build/run build-dist

How Has This Been Tested?

As above and locally updated the hello_world example plugin to test the conditions (no parents and with parents.agent).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Don't assume config.yml has a parent key as it's not required
(and for example lcnaf does not).
Copy link
Copy Markdown
Collaborator

@brianzelip brianzelip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing locally via the provided commands was a little off but this code works in PR #3014 so approving it now.

@brianzelip brianzelip merged commit 33f8dfd into archivesspace:master Sep 24, 2023
@cdibella cdibella added this to the 3.5.0 milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants