Skip to content

ANW-504: adding support for marking agent links as primary#2991

Merged
quoideneuf merged 9 commits intomasterfrom
ANW-504
May 16, 2023
Merged

ANW-504: adding support for marking agent links as primary#2991
quoideneuf merged 9 commits intomasterfrom
ANW-504

Conversation

@avatar382
Copy link
Copy Markdown
Collaborator

@avatar382 avatar382 commented Apr 27, 2023

Description

adding support for marking agent links as primary

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/jira/software/c/projects/ANW/issues/ANW-504

How Has This Been Tested?

manual and unit testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@avatar382 avatar382 marked this pull request as draft April 27, 2023 16:25
@avatar382 avatar382 marked this pull request as ready for review May 4, 2023 16:40
@quoideneuf
Copy link
Copy Markdown
Contributor

quoideneuf commented May 4, 2023 •
edited
Loading

@avatar382 You can fix the JS linting issues using the fix commands. See below:

archivesspace-> npm run
Scripts available in [email protected] via `npm run-script`:
  eslint:ci
    eslint frontend/ public/
  eslint:fix
    eslint --fix frontend/ public/
  stylelint:ci
    stylelint '{frontend,public}/**/*.{css,less,scss}' -f verbose
  stylelint:fix
    stylelint '{frontend,public}/**/*.{css,less,scss}' -f verbose --fix
  prettier:ci
    prettier --check frontend/ public/
  prettier:fix
    prettier --write frontend/ public/

@avatar382
Copy link
Copy Markdown
Collaborator Author

avatar382 commented May 4, 2023 •
edited
Loading

@quoideneuf I'm getting the Derby error we discussed running any of the resources.spec selenium tests. They're all failing with the same error for me locally.

This is the error I'm getting:

JSONModel::ValidationException:
[java]         #<:ValidationException: {:errors=>{"db_error"=>["Database integrity constraint conflict: Java::JavaSql::SQLSyntaxErrorException: Comparisons between 'INTEGER' and 'BOOLEAN' are not supported. 
Types must be comparable. String types must also have matching collation. If collation does not match, a 
possible solution is to cast operands to force them to the default collation (e.g. SELECT tablename FROM 
sys.systables WHERE CAST(tablename AS VARCHAR(128)) = 'T1')"]}}>

I'm setting the ASPACE_TEST_DB_URL like this to run the tests:

jdbc:derby:/home/manny/code/LibraryHost/archivesspace/archivesspace_demo_db;create=true;aspacedemo=true

@quoideneuf
Copy link
Copy Markdown
Contributor

quoideneuf commented May 5, 2023

@avatar382 the failure in the public test is a bug - it is fixed now in master so if you can't get it to pass try re-making the PR.

@quoideneuf quoideneuf self-assigned this May 11, 2023
@quoideneuf quoideneuf merged commit c68e48c into master May 16, 2023
@quoideneuf quoideneuf deleted the ANW-504 branch May 16, 2023 23:43
@cdibella cdibella added this to the 3.5.0 milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@quoideneuf quoideneuf quoideneuf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@quoideneuf quoideneuf

Labels

None yet

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@avatar382 @quoideneuf @cdibella