Skip to content

Spack: add dev version#2150

Merged
brenthuisman merged 14 commits intoarbor-sim:masterfrom
brenthuisman:spack/tip_from_eleni
Jul 10, 2023
Merged

Spack: add dev version#2150
brenthuisman merged 14 commits intoarbor-sim:masterfrom
brenthuisman:spack/tip_from_eleni

Conversation

@brenthuisman
Copy link
Copy Markdown
Contributor

@brenthuisman brenthuisman commented Jul 7, 2023

  • Upstream Spack changes forces any version that will be built to be explicitly listed in package.py. See Improve version, version range, and version list syntax and behavior spack/spack#36273
  • This version is only provided if a local VERSION is found (implying presence of Arbor source). If not, building that version would fail.
  • Temporarily disabled recently added Python tests in the workflow file, because dev-builds don't install the package, and thus the tests and examples won't run. I'm looking into a solution, but don't want to hold merging this PR up.

@brenthuisman brenthuisman marked this pull request as ready for review July 7, 2023 16:46
@brenthuisman brenthuisman added this to the v0.9 milestone Jul 7, 2023
Copy link
Copy Markdown
Contributor

@boeschf boeschf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good. I think it'd be good to enable the examples/tests again, but I agree that this can wait for now.

@brenthuisman brenthuisman merged commit 31f4e36 into arbor-sim:master Jul 10, 2023
@brenthuisman brenthuisman deleted the spack/tip_from_eleni branch July 10, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants