-
Notifications
You must be signed in to change notification settings - Fork 110
Closed
Description
If you import arangojs in a typescript project without including the dom lib, you currently get three errors
node_modules/arangojs/databases.d.ts:2284:43 - error TS2304: Cannot find name 'File'.
2284 installService(mount: string, source: File | Blob | string, options?: services.InstallServiceOptions): Promise<services.ServiceDescription>;
~~~~
node_modules/arangojs/databases.d.ts:2318:43 - error TS2304: Cannot find name 'File'.
2318 replaceService(mount: string, source: File | Blob | string, options?: services.ReplaceServiceOptions): Promise<services.ServiceDescription>;
~~~~
node_modules/arangojs/databases.d.ts:2352:43 - error TS2304: Cannot find name 'File'.
2352 upgradeService(mount: string, source: File | Blob | string, options?: services.UpgradeServiceOptions): Promise<services.ServiceDescription>;
Adding dom to the lib fixes this, but this has a drawback: You no longer get a type error if you accidentally use a symbol that's available in browsers but not in Node.js. For server-side development, it's better not to include "dom" to catch these errors.
I think the File | can just be removed. as File extends Blob: https://github.com/microsoft/TypeScript/blob/717d05cc2d528deb51cf7785bdd71891935d19a8/src/lib/dom.generated.d.ts#L8734
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels