Update pylint to 2.5.2 #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 43.39% 43.39%
=======================================
Files 2 2
Lines 53 53
=======================================
Hits 23 23
Misses 30 30 Continue to review full report at Codecov.
|
Owner
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 24, 2020
8: Update mock to 4.0.2 r=aragilar a=pyup-bot This PR updates [mock](https://pypi.org/project/mock) from **3.0.5** to **4.0.2**. <details> <summary>Changelog</summary> ### 4.0.2 ``` ----- - Issue 39915: Ensure :attr:`unittest.mock.AsyncMock.await_args_list` has call objects in the order of awaited arguments instead of using :attr:`unittest.mock.Mock.call_args` which has the last value of the call. Patch by Karthikeyan Singaravelan. ``` ### 4.0.1 ``` ----- - Remove the universal marker from the wheel. ``` ### 4.0.0 ``` ----- - No Changes from 4.0.0b1. ``` ### 4.0.0b1 ``` ------- - The release is a fresh cut of cpython's `4a686504`__. All changes to :mod:`mock` from that commit and before are included in this release along with the subsequent changes listed below. __ python/cpython@4a68650 - Issue 37972: Subscripts to the `unittest.mock.call` objects now receive the same chaining mechanism as any other custom attributes, so that the following usage no longer raises a `TypeError`: call().foo().__getitem__('bar') Patch by blhsing - Issue 38839: Fix some unused functions in tests. Patch by Adam Johnson. - Issue 39485: Fix a bug in :func:`unittest.mock.create_autospec` that would complain about the wrong number of arguments for custom descriptors defined in an extension module returning functions. - Issue 39082: Allow AsyncMock to correctly patch static/class methods - Issue 38093: Fixes AsyncMock so it doesn't crash when used with AsyncContextManagers or AsyncIterators. - Issue 38859: AsyncMock now returns StopAsyncIteration on the exaustion of a side_effects iterable. Since PEP-479 its Impossible to raise a StopIteration exception from a coroutine. - Issue 38163: Child mocks will now detect their type as either synchronous or asynchronous, asynchronous child mocks will be AsyncMocks and synchronous child mocks will be either MagicMock or Mock (depending on their parent type). - Issue 38473: Use signature from inner mock for autospecced methods attached with :func:`unittest.mock.attach_mock`. Patch by Karthikeyan Singaravelan. - Issue 38136: Changes AsyncMock call count and await count to be two different counters. Now await count only counts when a coroutine has been awaited, not when it has been called, and vice-versa. Update the documentation around this. - Issue 37555: Fix `NonCallableMock._call_matcher` returning tuple instead of `_Call` object when `self._spec_signature` exists. Patch by Elizabeth Uselton - Issue 37251: Remove `__code__` check in AsyncMock that incorrectly evaluated function specs as async objects but failed to evaluate classes with `__await__` but no `__code__` attribute defined as async objects. - Issue 38669: Raise :exc:`TypeError` when passing target as a string with :meth:`unittest.mock.patch.object`. - Issue 25597: Ensure, if ``wraps`` is supplied to :class:`unittest.mock.MagicMock`, it is used to calculate return values for the magic methods instead of using the default return values. Patch by Karthikeyan Singaravelan. - Issue 38108: Any synchronous magic methods on an AsyncMock now return a MagicMock. Any asynchronous magic methods on a MagicMock now return an AsyncMock. - Issue 21478: Record calls to parent when autospecced object is attached to a mock using :func:`unittest.mock.attach_mock`. Patch by Karthikeyan Singaravelan. - Issue 38857: AsyncMock fix for return values that are awaitable types. This also covers side_effect iterable values that happend to be awaitable, and wraps callables that return an awaitable type. Before these awaitables were being awaited instead of being returned as is. - Issue 38932: Mock fully resets child objects on reset_mock(). Patch by Vegard Stikbakke - Issue 37685: Fixed ``__eq__``, ``__lt__`` etc implementations in some classes. They now return :data:`NotImplemented` for unsupported type of the other operand. This allows the other operand to play role (for example the equality comparison with :data:`~unittest.mock.ANY` will return ``True``). - Issue 37212: :func:`unittest.mock.call` now preserves the order of keyword arguments in repr output. Patch by Karthikeyan Singaravelan. - Issue 37828: Fix default mock name in :meth:`unittest.mock.Mock.assert_called` exceptions. Patch by Abraham Toriz Cruz. - Issue 36871: Improve error handling for the assert_has_calls and assert_has_awaits methods of mocks. Fixed a bug where any errors encountered while binding the expected calls to the mock's spec were silently swallowed, leading to misleading error output. - Issue 21600: Fix :func:`mock.patch.stopall` to stop active patches that were created with :func:`mock.patch.dict`. - Issue 38161: Removes _AwaitEvent from AsyncMock. - Issue 36871: Ensure method signature is used instead of constructor signature of a class while asserting mock object against method calls. Patch by Karthikeyan Singaravelan. ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/mock - Changelog: https://pyup.io/changelogs/mock/ - Docs: http://mock.readthedocs.org/en/latest/ </details> 10: Update pylint to 2.5.2 r=aragilar a=pyup-bot This PR updates [pylint](https://pypi.org/project/pylint) from **2.4.3** to **2.5.2**. <details> <summary>Changelog</summary> ### 2.5.2 ``` =========================== Release date: 2020-05-05 * ``pylint.Run`` accepts ``do_exit`` as a deprecated parameter Close 3590 ``` ### 2.5.1 ``` =========================== Release date: 2020-05-05 * Fix a crash in `method-hidden` lookup for unknown base classes Close 3527 * Revert pylint.Run's `exit` parameter to ``do_exit`` This has been inadvertently changed several releases ago to ``do_exit``. Close 3533 * ``no-value-for-parameter`` variadic detection has improved for assign statements Close 3563 * Allow package files to be properly discovered with multiple jobs Close 3524 * Allow linting directories without `__init__.py` which was a regression in 2.5. Close 3528 ``` ### 2.5.0 ``` =========================== Release date: 2020-04-27 * Fix a false negative for ``undefined-variable`` when using class attribute in comprehension. Close 3494 * Fix a false positive for ``undefined-variable`` when using class attribute in decorator or as type hint. Close 511 Close 1976 * Remove HTML quoting of messages in JSON output. Close 2769 * Adjust the `invalid-name` rule to work with non-ASCII identifiers and add the `non-ascii-name` rule. Close 2725 * Positional-only arguments are taken in account for ``useless-super-delegation`` * ``unidiomatic-typecheck`` is no longer emitted for ``in`` and ``not in`` operators Close 3337 * Positional-only argument annotations are taken in account for ``unused-import`` Close 3462 * Add a command to list available extensions. * Allow used variables to be properly consumed when different checks are enabled / disabled Close 3445 * Fix dangerous-default-value rule to account for keyword argument defaults Close 3373 * Fix a false positive of ``self-assigning-variable`` on tuple unpacking. Close 3433 * ``no-self-use`` is no longer emitted for typing stubs. Close 3439 * Fix a false positive for ``undefined-variable`` when ``__class__`` is used Close 3090 * Emit ``invalid-name`` for variables defined in loops at module level. Close 2695 * Add a check for cases where the second argument to `isinstance` is not a type. Close 3308 * Add 'notes-rgx' option, to be used for fixme check. Close 2874 * ``function-redefined`` exempts function redefined on a condition. Close 2410 * ``typing.overload`` functions are exempted from docstring checks Close 3350 * Emit ``invalid-overridden-method`` for improper async def overrides. Close 3355 * Do not allow ``python -m pylint ...`` to import user code ``python -m pylint ...`` adds the current working directory as the first element of ``sys.path``. This opens up a potential security hole where ``pylint`` will import user level code as long as that code resides in modules having the same name as stdlib or pylint's own modules. Close 3386 * Add `dummy-variables-rgx` option for `_redeclared-assigned-name` check. Close 3341 * Fixed graph creation for relative paths * Add a check for asserts on string literals. Close 3284 * `not in` is considered iterating context for some of the Python 3 porting checkers. * A new check `inconsistent-quotes` was added. * Add a check for non string assignment to __name__ attribute. Close 583 * `__pow__`, `__imatmul__`, `__trunc__`, `__floor__`, and `__ceil__` are recognized as special method names. Close 3281 * Added errors for protocol functions when invalid return types are detected. E0304 (invalid-bool-returned): __bool__ did not return a bool E0305 (invalid-index-returned): __index__ did not return an integer E0306 (invalid-repr-returned): __repr__ did not return a string E0307 (invalid-str-returned): __str__ did not return a string E0308 (invalid-bytes-returned): __bytes__ did not return a string E0309 (invalid-hash-returned): __hash__ did not return an integer E0310 (invalid-length-hint-returned): __length_hint__ did not return a non-negative integer E0311 (invalid-format-returned): __format__ did not return a string E0312 (invalid-getnewargs-returned): __getnewargs__ did not return a tuple E0313 (invalid-getnewargs-ex-returned): __getnewargs_ex__ did not return a tuple of the form (tuple, dict) Close 560 * ``missing-*-docstring`` can look for ``__doc__`` assignments. Close 3301 * ``undefined-variable`` can now find undefined loop iterables Close 498 * ``safe_infer`` can infer a value as long as all the paths share the same type. Close 2503 * Add a --fail-under <score> flag, also configurable in a .pylintrc file. If the final score is more than the specified score, it's considered a success and pylint exits with exitcode 0. Otherwise, it's considered a failure and pylint exits with its current exitcode based on the messages issued. Close 2242 * Don't emit ``line-too-long`` for multilines when `disable=line-too-long` comment stands at their end Close 2957 * Fixed an ``AttributeError`` caused by improper handling of ``dataclasses`` inference in ``pyreverse`` Close 3256 * Do not exempt bare except from ``undefined-variable`` and similar checks If a node was wrapped in a ``TryExcept``, ``pylint`` was taking a hint from the except handler when deciding to emit or not a message. We were treating bare except as a fully fledged ignore but only the corresponding exceptions should be handled that way (e.g. ``NameError`` or ``ImportError``) Close 3235 * No longer emit ``assignment-from-no-return`` when a function only raises an exception Close 3218 * Allow import aliases to exempt ``import-error`` when used in type annotations. Close 3178 * ``Ellipsis` is exempted from ``multiple-statements`` for function overloads. Close 3224 * No longer emit ``invalid-name`` for non-constants found at module level. Pylint was taking the following statement from PEP-8 too far, considering all module level variables as constants, which is not what the statement is saying: `Constants are usually defined on a module level and written in all capital letters with underscores separating words.` Close 3111 Close 3132 * Allow ``implicit-str-concat-in-sequence`` to be emitted for string juxtaposition Close 3030 * ``implicit-str-concat-in-sequence`` was renamed ``implicit-str-concat`` * The ``json`` reporter no longer bypasses ``redirect_stdout``. Close 3227 * Move ``NoFileError``, ``OutputLine``, ``FunctionalTestReporter``, ``FunctionalTestFile``, ``LintModuleTest`` and related methods from ``test_functional.py`` to ``pylint.testutils`` to help testing for 3rd party pylint plugins. * Can read config from a setup.cfg or pyproject.toml file. Close 617 * Fix exception-escape false positive with generators Close 3128 * ``inspect.getargvalues`` is no longer marked as deprecated. * A new check ``f-string-without-interpolation`` was added Close 3190 * Flag mutable ``collections.*`` utilities as dangerous defaults Close 3183 * ``docparams`` extension supports multiple types in raises sections. Multiple types can also be separated by commas in all valid sections. Closes 2729 * Allow parallel linting when run under Prospector * Fixed false positives of ``method-hidden`` when a subclass defines the method that is being hidden. Closes 414 * Python 3 porting mode is 30-50% faster on most codebases * Python 3 porting mode no longer swallows syntax errors Closes 2956 * Pass the actual PyLinter object to sub processes to allow using custom PyLinter classes. PyLinter object (and all its members except reporter) needs to support pickling so the PyLinter object can be passed to worker processes. * Clean up setup.py Make pytest-runner a requirement only if running tests, similar to McCabe. Clean up the setup.py file, resolving a number of warnings around it. * Handle SyntaxError in files passed via ``--from-stdin`` option Pylint no longer outputs a traceback, if a file, read from stdin, contains a syntaxerror. * Fix uppercase style to disallow 3+ uppercase followed by lowercase. * Fixed ``undefined-variable`` and ``unused-import`` false positives when using a metaclass via an attribute. Close 1603 * Emit ``unused-argument`` for functions that partially uses their argument list before raising an exception. Close 3246 * Fixed ``broad_try_clause`` extension to check try/finally statements and to check for nested statements (e.g., inside of an ``if`` statement). * Recognize classes explicitly inheriting from ``abc.ABC`` or having an ``abc.ABCMeta`` metaclass as abstract. This makes them not trigger W0223. Closes 3098 * Fix overzealous `arguments-differ` when overridden function uses variadics No message is emitted if the overriding function provides positional or keyword variadics in its signature that can feasibly accept and pass on all parameters given by the overridden function. Close 1482 Close 1553 * Multiple types of string formatting are allowed in logging functions. The `logging-fstring-interpolation` message has been brought back to allow multiple types of string formatting to be used. Close 3361 ``` ### 2.4.4 ``` =========================== Release date: 2019-11-13 * Exempt all the names found in type annotations from ``unused-import`` The previous code was assuming that only ``typing`` names need to be exempted, but we need to do that for the rest of the type comment names as well. Close 3112 * Relax type import detection for names that do not come from the ``typing`` module Close 3191 ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pylint - Changelog: https://pyup.io/changelogs/pylint/ - Repo: https://github.com/PyCQA/pylint </details> Co-authored-by: pyup-bot <[email protected]>
Contributor
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
May 24, 2020
10: Update pylint to 2.5.2 r=aragilar a=pyup-bot This PR updates [pylint](https://pypi.org/project/pylint) from **2.4.3** to **2.5.2**. <details> <summary>Changelog</summary> ### 2.5.2 ``` =========================== Release date: 2020-05-05 * ``pylint.Run`` accepts ``do_exit`` as a deprecated parameter Close 3590 ``` ### 2.5.1 ``` =========================== Release date: 2020-05-05 * Fix a crash in `method-hidden` lookup for unknown base classes Close 3527 * Revert pylint.Run's `exit` parameter to ``do_exit`` This has been inadvertently changed several releases ago to ``do_exit``. Close 3533 * ``no-value-for-parameter`` variadic detection has improved for assign statements Close 3563 * Allow package files to be properly discovered with multiple jobs Close 3524 * Allow linting directories without `__init__.py` which was a regression in 2.5. Close 3528 ``` ### 2.5.0 ``` =========================== Release date: 2020-04-27 * Fix a false negative for ``undefined-variable`` when using class attribute in comprehension. Close 3494 * Fix a false positive for ``undefined-variable`` when using class attribute in decorator or as type hint. Close 511 Close 1976 * Remove HTML quoting of messages in JSON output. Close 2769 * Adjust the `invalid-name` rule to work with non-ASCII identifiers and add the `non-ascii-name` rule. Close 2725 * Positional-only arguments are taken in account for ``useless-super-delegation`` * ``unidiomatic-typecheck`` is no longer emitted for ``in`` and ``not in`` operators Close 3337 * Positional-only argument annotations are taken in account for ``unused-import`` Close 3462 * Add a command to list available extensions. * Allow used variables to be properly consumed when different checks are enabled / disabled Close 3445 * Fix dangerous-default-value rule to account for keyword argument defaults Close 3373 * Fix a false positive of ``self-assigning-variable`` on tuple unpacking. Close 3433 * ``no-self-use`` is no longer emitted for typing stubs. Close 3439 * Fix a false positive for ``undefined-variable`` when ``__class__`` is used Close 3090 * Emit ``invalid-name`` for variables defined in loops at module level. Close 2695 * Add a check for cases where the second argument to `isinstance` is not a type. Close 3308 * Add 'notes-rgx' option, to be used for fixme check. Close 2874 * ``function-redefined`` exempts function redefined on a condition. Close 2410 * ``typing.overload`` functions are exempted from docstring checks Close 3350 * Emit ``invalid-overridden-method`` for improper async def overrides. Close 3355 * Do not allow ``python -m pylint ...`` to import user code ``python -m pylint ...`` adds the current working directory as the first element of ``sys.path``. This opens up a potential security hole where ``pylint`` will import user level code as long as that code resides in modules having the same name as stdlib or pylint's own modules. Close 3386 * Add `dummy-variables-rgx` option for `_redeclared-assigned-name` check. Close 3341 * Fixed graph creation for relative paths * Add a check for asserts on string literals. Close 3284 * `not in` is considered iterating context for some of the Python 3 porting checkers. * A new check `inconsistent-quotes` was added. * Add a check for non string assignment to __name__ attribute. Close 583 * `__pow__`, `__imatmul__`, `__trunc__`, `__floor__`, and `__ceil__` are recognized as special method names. Close 3281 * Added errors for protocol functions when invalid return types are detected. E0304 (invalid-bool-returned): __bool__ did not return a bool E0305 (invalid-index-returned): __index__ did not return an integer E0306 (invalid-repr-returned): __repr__ did not return a string E0307 (invalid-str-returned): __str__ did not return a string E0308 (invalid-bytes-returned): __bytes__ did not return a string E0309 (invalid-hash-returned): __hash__ did not return an integer E0310 (invalid-length-hint-returned): __length_hint__ did not return a non-negative integer E0311 (invalid-format-returned): __format__ did not return a string E0312 (invalid-getnewargs-returned): __getnewargs__ did not return a tuple E0313 (invalid-getnewargs-ex-returned): __getnewargs_ex__ did not return a tuple of the form (tuple, dict) Close 560 * ``missing-*-docstring`` can look for ``__doc__`` assignments. Close 3301 * ``undefined-variable`` can now find undefined loop iterables Close 498 * ``safe_infer`` can infer a value as long as all the paths share the same type. Close 2503 * Add a --fail-under <score> flag, also configurable in a .pylintrc file. If the final score is more than the specified score, it's considered a success and pylint exits with exitcode 0. Otherwise, it's considered a failure and pylint exits with its current exitcode based on the messages issued. Close 2242 * Don't emit ``line-too-long`` for multilines when `disable=line-too-long` comment stands at their end Close 2957 * Fixed an ``AttributeError`` caused by improper handling of ``dataclasses`` inference in ``pyreverse`` Close 3256 * Do not exempt bare except from ``undefined-variable`` and similar checks If a node was wrapped in a ``TryExcept``, ``pylint`` was taking a hint from the except handler when deciding to emit or not a message. We were treating bare except as a fully fledged ignore but only the corresponding exceptions should be handled that way (e.g. ``NameError`` or ``ImportError``) Close 3235 * No longer emit ``assignment-from-no-return`` when a function only raises an exception Close 3218 * Allow import aliases to exempt ``import-error`` when used in type annotations. Close 3178 * ``Ellipsis` is exempted from ``multiple-statements`` for function overloads. Close 3224 * No longer emit ``invalid-name`` for non-constants found at module level. Pylint was taking the following statement from PEP-8 too far, considering all module level variables as constants, which is not what the statement is saying: `Constants are usually defined on a module level and written in all capital letters with underscores separating words.` Close 3111 Close 3132 * Allow ``implicit-str-concat-in-sequence`` to be emitted for string juxtaposition Close 3030 * ``implicit-str-concat-in-sequence`` was renamed ``implicit-str-concat`` * The ``json`` reporter no longer bypasses ``redirect_stdout``. Close 3227 * Move ``NoFileError``, ``OutputLine``, ``FunctionalTestReporter``, ``FunctionalTestFile``, ``LintModuleTest`` and related methods from ``test_functional.py`` to ``pylint.testutils`` to help testing for 3rd party pylint plugins. * Can read config from a setup.cfg or pyproject.toml file. Close 617 * Fix exception-escape false positive with generators Close 3128 * ``inspect.getargvalues`` is no longer marked as deprecated. * A new check ``f-string-without-interpolation`` was added Close 3190 * Flag mutable ``collections.*`` utilities as dangerous defaults Close 3183 * ``docparams`` extension supports multiple types in raises sections. Multiple types can also be separated by commas in all valid sections. Closes 2729 * Allow parallel linting when run under Prospector * Fixed false positives of ``method-hidden`` when a subclass defines the method that is being hidden. Closes 414 * Python 3 porting mode is 30-50% faster on most codebases * Python 3 porting mode no longer swallows syntax errors Closes 2956 * Pass the actual PyLinter object to sub processes to allow using custom PyLinter classes. PyLinter object (and all its members except reporter) needs to support pickling so the PyLinter object can be passed to worker processes. * Clean up setup.py Make pytest-runner a requirement only if running tests, similar to McCabe. Clean up the setup.py file, resolving a number of warnings around it. * Handle SyntaxError in files passed via ``--from-stdin`` option Pylint no longer outputs a traceback, if a file, read from stdin, contains a syntaxerror. * Fix uppercase style to disallow 3+ uppercase followed by lowercase. * Fixed ``undefined-variable`` and ``unused-import`` false positives when using a metaclass via an attribute. Close 1603 * Emit ``unused-argument`` for functions that partially uses their argument list before raising an exception. Close 3246 * Fixed ``broad_try_clause`` extension to check try/finally statements and to check for nested statements (e.g., inside of an ``if`` statement). * Recognize classes explicitly inheriting from ``abc.ABC`` or having an ``abc.ABCMeta`` metaclass as abstract. This makes them not trigger W0223. Closes 3098 * Fix overzealous `arguments-differ` when overridden function uses variadics No message is emitted if the overriding function provides positional or keyword variadics in its signature that can feasibly accept and pass on all parameters given by the overridden function. Close 1482 Close 1553 * Multiple types of string formatting are allowed in logging functions. The `logging-fstring-interpolation` message has been brought back to allow multiple types of string formatting to be used. Close 3361 ``` ### 2.4.4 ``` =========================== Release date: 2019-11-13 * Exempt all the names found in type annotations from ``unused-import`` The previous code was assuming that only ``typing`` names need to be exempted, but we need to do that for the rest of the type comment names as well. Close 3112 * Relax type import detection for names that do not come from the ``typing`` module Close 3191 ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pylint - Changelog: https://pyup.io/changelogs/pylint/ - Repo: https://github.com/PyCQA/pylint </details> Co-authored-by: pyup-bot <[email protected]>
Contributor
|
Build failed: |
Owner
|
bors r- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates pylint from 2.4.3 to 2.5.2.
Changelog
2.5.2
2.5.1
2.5.0
2.4.4
Links