Skip to content

feat: add http/https cases to setWebpackPublicPath#169

Merged
with-heart merged 2 commits intoarackaf:masterfrom
fireairforce:master
Sep 29, 2019
Merged

feat: add http/https cases to setWebpackPublicPath#169
with-heart merged 2 commits intoarackaf:masterfrom
fireairforce:master

Conversation

@fireairforce
Copy link
Copy Markdown
Contributor

fix the issue#168

@fireairforce fireairforce changed the title feat:fix bugs on setWebpackPublicPath #168 feat:fix bugs on setWebpackPublicPath Sep 16, 2019
@with-heart with-heart changed the title feat:fix bugs on setWebpackPublicPath feat: add http/https cases to setWebpackPublicPath Sep 19, 2019
@with-heart
Copy link
Copy Markdown
Collaborator

Hi @fireairforce, thanks for the PR! I added a commit that adds tests for the new http/https cases. Will merge and get that published shortly.

@fireairforce
Copy link
Copy Markdown
Contributor Author

OK

@fireairforce
Copy link
Copy Markdown
Contributor Author

I hope that you can aslo update the README.md, i see some issues on how to set outputpath

@fireairforce
Copy link
Copy Markdown
Contributor Author

Hello,Can you please publish this pr...i need to use this in my project...thx

@with-heart with-heart merged commit 067f5c7 into arackaf:master Sep 29, 2019
@with-heart
Copy link
Copy Markdown
Collaborator

Hi @fireairforce, sorry about the delay. This is published as [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants