add new feature: addBabelPluginOutSideOfApp and update snapshot#123
add new feature: addBabelPluginOutSideOfApp and update snapshot#123with-heart merged 5 commits intoarackaf:masterfrom Terryand:master
Conversation
Terryand
commented
Jul 8, 2019
Terryand
commented
- update getBabelLoader as cra2/3 acturally has two babel-loader relues. One is for appSrc and the other is for outside of app( like node_modules ).Different them by include/exclude options;
- add new feature: addBabelPluginOutSideOfApp. Now you can add plugin to the babel-loader which is for outside of app. Of course, test suits is updated together
- update snapshots: now the snapshots is more like to real cra2/3 webpack-config;
…he config will be more like cra2/3 webpack-config);user can customize babel loader for outside of the app
There was a problem hiding this comment.
Awesome work! This looks great @Terryand.
I think the only thing I'd change now that I'm thinking about it would be to call them addExternalBabelPlugin and addExternalBabelPlugins. I think that combined with docs in the readme would make it very obvious what they do. OutSideOfApp is confusing imo.
What do you think?
Also could you add examples of each at the bottom of readme.md?
with-heart
left a comment
with-heart
left a comment
There was a problem hiding this comment.
Sorry for taking so long to get back to you. It's been a busy couple of weeks for me!
I added a few suggestions for api.md. If they look good to you, we can get this merged :)
|
That's ok and thanks a lot for these suggestions. |
|
Great work @Terryand! |
|
Published as |
|
Hey @Terryand, thanks again! I've added you to the project's contributors list :) |
2 participants
