feat: break apart codebase into modules#118
Merged
with-heart merged 4 commits intomasterfrom Jul 7, 2019
Merged
Conversation
This PR also moves the source files to `src/` folder.
Collaborator
Author
|
I need to find some people that have bandwidth to check out PRs. I'll ask some co-workers if they can assist for the time being. Since this is just re-arranging files, gonna merge and keep moving. |
This was referenced Jul 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #104 with some modifications to how the files were broken apart.
Overview
One function per file felt a little too shallow, so I broke things apart three major modules–
customizers,overrides, andutilities–and also moved everything tosrc/:customizersThese are all the functions that actually modify the config files. They're currently grouped by
webpackandbabel, which may not be entirely accurate, but I don't want to break this down anymore without more thought and discussion.Could eventually be split down even more into
enablersthat actually enable functionality and features andcustomizersthat simply modify existing configuration. Or something. Not sure it really even matters.overridesThis is just
overrideandoverrideDevServer. They felt special enough to house in their own file.utilitiesCurrently just
getBabelLoader. Should eventually have more functions that enable consumers to build their own plugins.src/I went ahead and moved everything over to
src/in preparation for #113.