Skip to content

feat: break apart codebase into modules#118

Merged
with-heart merged 4 commits intomasterfrom
feat/104-break-apart-into-modules
Jul 7, 2019
Merged

feat: break apart codebase into modules#118
with-heart merged 4 commits intomasterfrom
feat/104-break-apart-into-modules

Conversation

@with-heart
Copy link
Copy Markdown
Collaborator

@with-heart with-heart commented Jul 7, 2019

This PR closes #104 with some modifications to how the files were broken apart.

Overview

One function per file felt a little too shallow, so I broke things apart three major modules–customizers, overrides, and utilities–and also moved everything to src/:

src
├── customizers
│  ├── babel.js
│  ├── index.js
│  └── webpack.js
├── index.js
├── overrides.js
└── utilities.js

customizers

These are all the functions that actually modify the config files. They're currently grouped by webpack and babel, which may not be entirely accurate, but I don't want to break this down anymore without more thought and discussion.

Could eventually be split down even more into enablers that actually enable functionality and features and customizers that simply modify existing configuration. Or something. Not sure it really even matters.

overrides

This is just override and overrideDevServer. They felt special enough to house in their own file.

utilities

Currently just getBabelLoader. Should eventually have more functions that enable consumers to build their own plugins.

src/

I went ahead and moved everything over to src/ in preparation for #113.

@with-heart with-heart added this to the 1.0 milestone Jul 7, 2019
@with-heart
Copy link
Copy Markdown
Collaborator Author

I need to find some people that have bandwidth to check out PRs. I'll ask some co-workers if they can assist for the time being.

Since this is just re-arranging files, gonna merge and keep moving.

@with-heart with-heart merged commit 9bd7505 into master Jul 7, 2019
@with-heart with-heart deleted the feat/104-break-apart-into-modules branch July 7, 2019 16:53
@with-heart with-heart restored the feat/104-break-apart-into-modules branch August 10, 2019 16:41
@with-heart with-heart deleted the feat/104-break-apart-into-modules branch August 10, 2019 16:44
@with-heart with-heart restored the feat/104-break-apart-into-modules branch September 4, 2019 15:47
@with-heart with-heart deleted the feat/104-break-apart-into-modules branch September 4, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Break apart single-file index into modules

1 participant